Repository navigation
Conversation
a435c72 to
6dfec7f
Compare
|
Any more thoughts on this PR? |
|
So, this is intended for packets originating from applications that are bound to a device. After that, a table is selected to continue with the regular routing process. Is that right? I believe this should be a new parameter instead of applying with there is a single IP (no provided table ID case). It can take precedence over the IPs. Something like Also, why not using the VRF plugin instead? |
Yes. Because binding to IP addresses is problematic, as they are dynamically assigned.
Yes, probably setting this via a parameter is better.
Doesn't that require the application to be VRF aware? |
|
as far as I know, for vrf, you only need to use SO_BINDTODEVICE which I guess you are already using |
Yes, we're already using SO_BINDTODEVICE. How does the vrf plugin help here? |
…on outbound interface - UseOriginatingIf adds fallback rules for local sockets bound to the interface. - With automatic allocation, each family uses the SBR table for its first address. - With an explicit table, the caller provides the routes for every configured family. Signed-off-by: Neil Cook <neil.cook@noware.co.uk>
Signed-off-by: Neil Cook <neil.cook@noware.co.uk>
Signed-off-by: Neil Cook <neil.cook@noware.co.uk>
When using the sbr plugin with a CNI plugin such as multus, applications have to bind to the source IP address of the interface for the str plugin to work correctly. They cannot bind to the interface name, because the sbr plugin doesn't currently add a rule for the interface name.
This is problematic because it is straightforward to configure the name of a multus interface, however the IP address is usually assigned from a range, so the exact interface IP address to use is not known in advance unlike the interface name. It would thus be much easier for applications if the sbr plugin added a rule with the interface name in addition to the rule with the interface address.
This PR does exactly that - adds an additional rule with the outbound interface name, so that applications can configure the name of the interface to bind to, rather than having to know the interface IP address.
This functionality is only enabled if the new config option
useOriginatingIfis enabled. One oif rule is added per-address-family, using the first address it finds in that family.The functionality is deliberately additive, it still adds the IP-source rules and moves routes etc. as before. That allows applications binding specifically to interfaces to co-exist with applications that do not. The oif rule is always added last, to ensure that they continue to apply to applications only binding to source IP addresses.