Repository navigation
upstream @jef-n fix for cabundle (PDAL #5006) - #61
Merged
Merged
Conversation
connormanning
pushed a commit
that referenced
this pull request
Oct 30, 2026
Curl's move constructor (from #60) moved m_caPath, m_caInfo and m_proxy but not m_caBundle (added in #61). Pool fills m_curls with emplace_back, so the handles moved on reallocation lose the bundle: - CURL_CA_BUNDLE, ARBITER_CA_BUNDLE and http.caBundle are ignored on those handles, and curl falls back to its default CA file - CURL_CA_INFO / http.caInfo are unaffected Tested against a local HTTPS S3 stub signed by a private CA, with the CA given only via CURL_CA_BUNDLE or ARBITER_CA_BUNDLE: 5046813 (before #60) fetches the object, master (3e5dde7) fails the TLS handshake, this commit fetches it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.