Fix memory leak potential by not calling op.cancel()#191
Merged
Conversation
abb4539 to
2b4717d
Compare
Collaborator
|
Thanks for the fix! Can you clarify: "Updated ServeHTTP to pass op.request (carrying the sub-context) to downstream handlers on pass-through and unknown route paths."? |
6edd1c4 to
28be1c3
Compare
Signed-off-by: Kevin McDonald <kevin@sudorandom.com>
Signed-off-by: Kevin McDonald <kevin@sudorandom.com>
Signed-off-by: Kevin McDonald <kevin@sudorandom.com>
0653885 to
25b2e35
Compare
emcfarlane
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures the Transcoder request sub-context is always cancelled and correctly propagated to downstream handlers.
Changes
defer op.cancel()toServeHTTPto prevent context leaks.ServeHTTPto passop.request(carrying the sub-context) to downstream handlers onpass-through and unknown route paths.