Docker implementation [skip windows]#1219
Draft
Jrice1317 wants to merge 26 commits intoconda:mainfrom
Draft
Conversation
9fa7db8 to
9f20cbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Docker output support to constructor, generating a ready-to-use Dockerfile and optionally building the resulting image via
installer_type: dockeranddocker_build: truein the construct.yaml.Changes
New:
constructor/docker_build.py: Handles Docker output by rendering template and optionally building imageconstructor/dockerfile_template.tmpl: Template used to generate Dockerfileexamples/docker_build/construct.yaml: Example construct.yaml used for testingUpdated:
constructor/_schema.py: Addsdockertoinstaller_typeand addsdocker_base_image,docker_tag,docker_labelsconstructor/main.py: Addsdockerto installer typestests/test_examples.py: Addstest_docker_buildto cover Dockerfile generation, image build and smoke testNotes:
RuntimeErroris raised whenbase_imageis not providedChecklist - did you ...
newsdirectory (using the template) for the next release's release notes?