-
Notifications
You must be signed in to change notification settings - Fork 177
Move pkgs/env.txt lockfile to conda-meta/initial-state.explicit.txt to preserve it
#1059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
0a37e47
Expect env.txt in conda-meta
jaimergp 26a468d
Add implementation
jaimergp a593880
add news
jaimergp f9b3d0e
this one is not needed
jaimergp 1ece828
run extra_envs example only
jaimergp e178c1a
rename target location for lockfile
jaimergp ead76c9
pre-commit
jaimergp 5201e89
amend news
jaimergp a08a0aa
run uninstall _after_ assertions
jaimergp 3c9f357
revert
jaimergp 2661f02
Update tests/test_examples.py
jaimergp 9584854
Just use initial-state.explicit.txt as the input file for environment…
jaimergp 1fd9802
Merge branch 'lockfile-pkgs-txt' of github.com:jaimergp/constructor i…
jaimergp 550a98b
rename function name
jaimergp d194aee
Patch locations in PKG
jaimergp 26a464e
fix path in windows
jaimergp fe1e040
Refactor write_files()
jaimergp edce6e7
Fix some paths in windows
jaimergp 9dda4cd
finish docstring
jaimergp 2e3f3ff
pre-commit
jaimergp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| ### Enhancements | ||
|
|
||
| * Ship `conda-meta/initial-state.lockfile.txt` as a copy of the lockfile that provisions the initial state of each environment. (#1052 via #1059) | ||
|
|
||
| ### Bug fixes | ||
|
|
||
| * <news item> | ||
|
|
||
| ### Deprecations | ||
|
|
||
| * <news item> | ||
|
|
||
| ### Docs | ||
|
|
||
| * <news item> | ||
|
|
||
| ### Other | ||
|
|
||
| * <news item> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of renaming the
env.txtfile during the installation, why don't we just packageenv.txtasconda-meta/initial-state.lockfile.txtand use that file for the--fileargument?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That works too. I wanted to start with the smallest diff possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed. Let's see if I got it right :P