libmodbus Add version 3.1.12 and stop publishing revs for older versions#30083
Conversation
|
@uilianries I looked into the failing MacOs test and I think the build is already failing (log), because there are some errors of the type: I tried the cross-compilation on my (ubuntu 24.04) machine with gcc14 by running
Do I need to handle the cross-compilation case explicitly in my recipe, e.g. by using |
Signed-off-by: Uilian Ries <uilianr@jfrog.com>
Signed-off-by: Uilian Ries <uilianr@jfrog.com>
Signed-off-by: Uilian Ries <uilianr@jfrog.com>
|
@ottmar-zittlau Thank you for investigating the case! The problem was related to cflags not being respected: on OSX we pass I just updated your PR to use that patch, so we will not need to care about it in the future. I also removed version 1.3.11 from conandata.yml, as no other recipe in the Conan Center Index consumes libmodbus. No version will be removed from Conan Center; all packages will remain there. The only change is that CI will stop producing new revisions for those older versions. Regards! |
Signed-off-by: Uilian Ries <uilianr@jfrog.com>
|
The build https://github.com/conan-io/conan-center-index/pull/30083/checks?check_run_id=74180454570 failed due MSVC trying to consume GCC warning flags. This error was mitigated previously by applying a non-official patch to remove warning flags. I reported this case to the upstream, so we may have a proper fix in the future: stephane/libmodbus#846 As an alternative, I simplified the previous patch to only use those warning flags in case of using a supported compiler: 0627c3d |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
There was a problem hiding this comment.
@ottmar-zittlau Thank you for your PR! It looks good to me now! 😄
Reviewer Notes
- Latest version is 3.1.12: https://github.com/stephane/libmodbus/releases
- No other recipe is consuming libmodbus in Conan Center, so removing old versions from
conandata.ymlis fine; No package will be removed from Conan Center, all old version will remain available for download as before.
Maintainer Changes
- Dropped version 3.1.11 from
conandata.ymlas version 3.1.12 cover the same version, plus, more fixes. - Using official patch
0001-repect-cflags.patchfrom the upstream to deal with cflags. So far, we have had a custom implementation in this recipe. - Reported the upstream about MSVC error with warning flags: stephane/libmodbus#846
- Using a proposed patch, similar to the previous one, to avoid consuming Warning flags for non GCC compatible compilers
- Proposed a fix for ssize_t redefinition on Windows: stephane/libmodbus#847 - The same is now listed as
0003-fix-typedef-int.patch
|
@uilianries Thanks a lot for finishing this and explaining your changes! |
Summary
Add libmodbus/3.1.12
Motivation
Added libmodbus v3.1.12 because they fixed some issues on their side (stephane/libmodbus#829 & stephane/libmodbus#830) that complicate the current recipe.
Details
Added the new version and stopped publishing revs for older versions.
Add a 👍 reaction to pull requests you find important to help the team prioritize, thanks!