Skip to content

perf(sessions): skip the pty list socket probe when the pid already proves life #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myobie merged 1 commit into from
Jul 22, 2026
Merged

perf(sessions): skip the pty list socket probe when the pid already proves life #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/sessions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,8 +335,12 @@ export async function listSessions(): Promise<SessionInfo[]> {
const pid = readPid(name);
const pidAlive = pid !== null && isProcessAlive(pid);
// A reachable control socket proves the daemon is alive INDEPENDENTLY of
// whether we could read the pidfile this instant.
const socketReachable = await isSocketReachable(socketPath);
// whether we could read the pidfile this instant. Probe it ONLY when the
// pid doesn't already prove life: for a live pid the probe result is
// ignored (running either way), so skipping it avoids a per-session connect
// on the hot path and cuts the socket-connect contention that a `pty list`
// under concurrent multi-agent load would otherwise add.
const socketReachable = pidAlive ? true : await isSocketReachable(socketPath);

if (pidAlive || socketReachable) {
// Alive: a live process, or a reachable control socket (busy/mid-startup
Expand Down
Loading