fix(up): a worker crash dings its SUPERVISOR again, not just the CoS (crash-ding regression)

[myobie]

Finding (from the evals crash-ding cell)

On a worker crash, convoy up's crash-ding reaches the CoS/orchestrator but not the crashed worker's supervisor (cd-sup's inbox stays empty). Answer: this is a regression, not a stale expectation — the two-recipient design (CoS and the supervisor) is correct (it's the #48 design; the agent-file supervisor field and crashDingTargets' convoy.spawner branch exist for exactly this).

Root cause

crashDingTargets correctly pages the CoS (convoy.tier=cos) plus crashed.tags["convoy.spawner"] (the supervisor). But the declarative arc broke the wiring that sets convoy.spawner:

1. agentFileToSpec dropped supervisor — the declared supervisor never reached the launch path (the field was documented as "reconcile does not yet build the supervision tree from it").
2. writeAgentFiles stamped convoy.spawner from the launching process's ST_AGENT — which, in the declarative flow, is the convoy up host, not the parent. So a declared worker's convoy.spawner became the host (often == the CoS → deduped away), and its real supervisor was never dinged.

Fix

• carry supervisor on AgentSpec;
• map af.supervisor → spec.supervisor in agentFileToSpec;
• stamp convoy.spawner = spec.supervisor ?? process.env.ST_AGENT in writeAgentFiles — the declared supervisor is authoritative; ST_AGENT stays the fallback for the imperative convoy run path.

Tests

+2 regression tests (533 total pass, typecheck clean): agentFileToSpec carries supervisor; writeAgentFiles prefers the declared supervisor over the host's ST_AGENT (and falls back to ST_AGENT when none is declared).

For the eval cell

Keep the two-recipient expectation. Once this lands and the worker is launched fresh (the cell spins a new network each run) with --supervisor <cd-sup> declared, its pty.toml gets convoy.spawner = cd-sup, so a crash pages both cd-cos and cd-sup. (Already-running workers keep their old tag until re-rendered.)

🤖 Generated with Claude Code

https://claude.ai/code/session_01MCzqQKSpPiNX2ketyubByS