Repository navigation
Fix: Guard domestic hot water mapping against undefined lists - #97
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a TypeError (
Cannot read properties of undefined (reading '0')) occurring inmapHotWaterSourcesDatawhen thewaterStoragesection of the domestic hot water state is incomplete.The root cause was that
resolveStateomits sections that are not marked ascomplete, leading tostate.domesticHotWater.waterStoragebeingundefined. The code then attempted to accesswaterStorage[0]without optional chaining, causing the crash.Changes made in
mapping/domesticHotWaterMapper.ts:state.domesticHotWater.waterStorage[0]tostate.domesticHotWater.waterStorage?.[0]to safely handleundefinedvalues.?? []guards tostate.domesticHotWater.pipeworkandstate.domesticHotWater.hotWaterOutletswhen calling.filter()to prevent similarTypeErrors if these lists areundefined.Fixes EPB-CHECK-PART-L-FRONTEND-1B
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry at no cost. You can adjust this setting at any time.