Skip to content

fix(DK): use formal Danish holiday names and optimize observance notes #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
commenthol merged 1 commit into from
Jul 10, 2026
Merged

fix(DK): use formal Danish holiday names and optimize observance notes #632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions data/countries/DK.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,22 +34,25 @@ holidays:
05-01:
_name: 05-01
type: observance
note: Full holiday for blue collar workers
note: Not a public holiday; full day off for blue collar workers only
# @source https://cphpost.dk/2025-05-01/life-in-denmark/what-happens-on-the-1st-of-may/
2nd sunday in May:
_name: Mothers Day
type: observance
06-05:
_name: Constitution Day
type: observance
note: Shops are closed
note: Not a public holiday; shops closed by law
# @source https://www.retsinformation.dk/eli/lta/2019/515
easter 49:
_name: easter 49
easter 50:
_name: easter 50
12-24:
_name: 12-24
type: observance
note: Shops are closed
note: Not a public holiday; shops closed by law
# @source https://www.retsinformation.dk/eli/lta/2019/515
12-25:
_name: 12-25
12-26:
Expand Down
6 changes: 3 additions & 3 deletions data/names.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ names:
bs: Novogodisnji dan
ca: Any nou
cz: Nový rok
da: Nytår
da: Nytårsdag
de: Neujahr
el: Πρωτοχρονιά
es: Año Nuevo
Expand Down Expand Up @@ -351,7 +351,7 @@ names:
bg: Бъдни вечер
bs: Badnji dan
cz: Štědrý den
da: Juleaften
da: Juleaftensdag
de: Heiliger Abend
es: Nochebuena
et: jõululaupäev
Expand Down Expand Up @@ -627,7 +627,7 @@ names:
bg: Великден
bs: Vaskrs
cz: Velikonoční neděle
da: Påskesøndag
da: Påskedag
de: Ostersonntag
el: Πάσχα
es: Pascua
Expand Down
12 changes: 6 additions & 6 deletions test/fixtures/DK-2015.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"date": "2015-01-01 00:00:00",
"start": "2014-12-31T23:00:00.000Z",
"end": "2015-01-01T23:00:00.000Z",
"name": "Nytår",
"name": "Nytårsdag",
"type": "public",
"rule": "01-01",
"_weekday": "Thu"
Expand Down Expand Up @@ -39,7 +39,7 @@
"date": "2015-04-05 00:00:00",
"start": "2015-04-04T22:00:00.000Z",
"end": "2015-04-05T22:00:00.000Z",
"name": "Påskesøndag",
"name": "Påskedag",
"type": "public",
"rule": "easter",
"_weekday": "Sun"
Expand All @@ -59,7 +59,7 @@
"end": "2015-05-01T22:00:00.000Z",
"name": "1. maj",
"type": "observance",
"note": "Full holiday for blue collar workers",
"note": "Not a public holiday; full day off for blue collar workers only",
"rule": "05-01",
"_weekday": "Fri"
},
Expand Down Expand Up @@ -114,17 +114,17 @@
"end": "2015-06-05T22:00:00.000Z",
"name": "Grundlovsdag",
"type": "observance",
"note": "Shops are closed",
"note": "Not a public holiday; shops closed by law",
"rule": "06-05",
"_weekday": "Fri"
},
{
"date": "2015-12-24 00:00:00",
"start": "2015-12-23T23:00:00.000Z",
"end": "2015-12-24T23:00:00.000Z",
"name": "Juleaften",
"name": "Juleaftensdag",
"type": "observance",
"note": "Shops are closed",
"note": "Not a public holiday; shops closed by law",
"rule": "12-24",
"_weekday": "Thu"
},
Expand Down
12 changes: 6 additions & 6 deletions test/fixtures/DK-2016.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"date": "2016-01-01 00:00:00",
"start": "2015-12-31T23:00:00.000Z",
"end": "2016-01-01T23:00:00.000Z",
"name": "Nytår",
"name": "Nytårsdag",
"type": "public",
"rule": "01-01",
"_weekday": "Fri"
Expand Down Expand Up @@ -39,7 +39,7 @@
"date": "2016-03-27 00:00:00",
"start": "2016-03-26T23:00:00.000Z",
"end": "2016-03-27T22:00:00.000Z",
"name": "Påskesøndag",
"name": "Påskedag",
"type": "public",
"rule": "easter",
"_weekday": "Sun"
Expand Down Expand Up @@ -68,7 +68,7 @@
"end": "2016-05-01T22:00:00.000Z",
"name": "1. maj",
"type": "observance",
"note": "Full holiday for blue collar workers",
"note": "Not a public holiday; full day off for blue collar workers only",
"rule": "05-01",
"_weekday": "Sun"
},
Expand Down Expand Up @@ -114,17 +114,17 @@
"end": "2016-06-05T22:00:00.000Z",
"name": "Grundlovsdag",
"type": "observance",
"note": "Shops are closed",
"note": "Not a public holiday; shops closed by law",
"rule": "06-05",
"_weekday": "Sun"
},
{
"date": "2016-12-24 00:00:00",
"start": "2016-12-23T23:00:00.000Z",
"end": "2016-12-24T23:00:00.000Z",
"name": "Juleaften",
"name": "Juleaftensdag",
"type": "observance",
"note": "Shops are closed",
"note": "Not a public holiday; shops closed by law",
"rule": "12-24",
"_weekday": "Sat"
},
Expand Down
12 changes: 6 additions & 6 deletions test/fixtures/DK-2017.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"date": "2017-01-01 00:00:00",
"start": "2016-12-31T23:00:00.000Z",
"end": "2017-01-01T23:00:00.000Z",
"name": "Nytår",
"name": "Nytårsdag",
"type": "public",
"rule": "01-01",
"_weekday": "Sun"
Expand Down Expand Up @@ -39,7 +39,7 @@
"date": "2017-04-16 00:00:00",
"start": "2017-04-15T22:00:00.000Z",
"end": "2017-04-16T22:00:00.000Z",
"name": "Påskesøndag",
"name": "Påskedag",
"type": "public",
"rule": "easter",
"_weekday": "Sun"
Expand All @@ -59,7 +59,7 @@
"end": "2017-05-01T22:00:00.000Z",
"name": "1. maj",
"type": "observance",
"note": "Full holiday for blue collar workers",
"note": "Not a public holiday; full day off for blue collar workers only",
"rule": "05-01",
"_weekday": "Mon"
},
Expand Down Expand Up @@ -114,17 +114,17 @@
"end": "2017-06-05T22:00:00.000Z",
"name": "Grundlovsdag",
"type": "observance",
"note": "Shops are closed",
"note": "Not a public holiday; shops closed by law",
"rule": "06-05",
"_weekday": "Mon"
},
{
"date": "2017-12-24 00:00:00",
"start": "2017-12-23T23:00:00.000Z",
"end": "2017-12-24T23:00:00.000Z",
"name": "Juleaften",
"name": "Juleaftensdag",
"type": "observance",
"note": "Shops are closed",
"note": "Not a public holiday; shops closed by law",
"rule": "12-24",
"_weekday": "Sun"
},
Expand Down
12 changes: 6 additions & 6 deletions test/fixtures/DK-2018.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"date": "2018-01-01 00:00:00",
"start": "2017-12-31T23:00:00.000Z",
"end": "2018-01-01T23:00:00.000Z",
"name": "Nytår",
"name": "Nytårsdag",
"type": "public",
"rule": "01-01",
"_weekday": "Mon"
Expand Down Expand Up @@ -39,7 +39,7 @@
"date": "2018-04-01 00:00:00",
"start": "2018-03-31T22:00:00.000Z",
"end": "2018-04-01T22:00:00.000Z",
"name": "Påskesøndag",
"name": "Påskedag",
"type": "public",
"rule": "easter",
"_weekday": "Sun"
Expand Down Expand Up @@ -68,7 +68,7 @@
"end": "2018-05-01T22:00:00.000Z",
"name": "1. maj",
"type": "observance",
"note": "Full holiday for blue collar workers",
"note": "Not a public holiday; full day off for blue collar workers only",
"rule": "05-01",
"_weekday": "Tue"
},
Expand Down Expand Up @@ -114,17 +114,17 @@
"end": "2018-06-05T22:00:00.000Z",
"name": "Grundlovsdag",
"type": "observance",
"note": "Shops are closed",
"note": "Not a public holiday; shops closed by law",
"rule": "06-05",
"_weekday": "Tue"
},
{
"date": "2018-12-24 00:00:00",
"start": "2018-12-23T23:00:00.000Z",
"end": "2018-12-24T23:00:00.000Z",
"name": "Juleaften",
"name": "Juleaftensdag",
"type": "observance",
"note": "Shops are closed",
"note": "Not a public holiday; shops closed by law",
"rule": "12-24",
"_weekday": "Mon"
},
Expand Down
12 changes: 6 additions & 6 deletions test/fixtures/DK-2019.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"date": "2019-01-01 00:00:00",
"start": "2018-12-31T23:00:00.000Z",
"end": "2019-01-01T23:00:00.000Z",
"name": "Nytår",
"name": "Nytårsdag",
"type": "public",
"rule": "01-01",
"_weekday": "Tue"
Expand Down Expand Up @@ -39,7 +39,7 @@
"date": "2019-04-21 00:00:00",
"start": "2019-04-20T22:00:00.000Z",
"end": "2019-04-21T22:00:00.000Z",
"name": "Påskesøndag",
"name": "Påskedag",
"type": "public",
"rule": "easter",
"_weekday": "Sun"
Expand All @@ -59,7 +59,7 @@
"end": "2019-05-01T22:00:00.000Z",
"name": "1. maj",
"type": "observance",
"note": "Full holiday for blue collar workers",
"note": "Not a public holiday; full day off for blue collar workers only",
"rule": "05-01",
"_weekday": "Wed"
},
Expand Down Expand Up @@ -96,7 +96,7 @@
"end": "2019-06-05T22:00:00.000Z",
"name": "Grundlovsdag",
"type": "observance",
"note": "Shops are closed",
"note": "Not a public holiday; shops closed by law",
"rule": "06-05",
"_weekday": "Wed"
},
Expand All @@ -122,9 +122,9 @@
"date": "2019-12-24 00:00:00",
"start": "2019-12-23T23:00:00.000Z",
"end": "2019-12-24T23:00:00.000Z",
"name": "Juleaften",
"name": "Juleaftensdag",
"type": "observance",
"note": "Shops are closed",
"note": "Not a public holiday; shops closed by law",
"rule": "12-24",
"_weekday": "Tue"
},
Expand Down
12 changes: 6 additions & 6 deletions test/fixtures/DK-2020.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"date": "2020-01-01 00:00:00",
"start": "2019-12-31T23:00:00.000Z",
"end": "2020-01-01T23:00:00.000Z",
"name": "Nytår",
"name": "Nytårsdag",
"type": "public",
"rule": "01-01",
"_weekday": "Wed"
Expand Down Expand Up @@ -39,7 +39,7 @@
"date": "2020-04-12 00:00:00",
"start": "2020-04-11T22:00:00.000Z",
"end": "2020-04-12T22:00:00.000Z",
"name": "Påskesøndag",
"name": "Påskedag",
"type": "public",
"rule": "easter",
"_weekday": "Sun"
Expand All @@ -59,7 +59,7 @@
"end": "2020-05-01T22:00:00.000Z",
"name": "1. maj",
"type": "observance",
"note": "Full holiday for blue collar workers",
"note": "Not a public holiday; full day off for blue collar workers only",
"rule": "05-01",
"_weekday": "Fri"
},
Expand Down Expand Up @@ -114,17 +114,17 @@
"end": "2020-06-05T22:00:00.000Z",
"name": "Grundlovsdag",
"type": "observance",
"note": "Shops are closed",
"note": "Not a public holiday; shops closed by law",
"rule": "06-05",
"_weekday": "Fri"
},
{
"date": "2020-12-24 00:00:00",
"start": "2020-12-23T23:00:00.000Z",
"end": "2020-12-24T23:00:00.000Z",
"name": "Juleaften",
"name": "Juleaftensdag",
"type": "observance",
"note": "Shops are closed",
"note": "Not a public holiday; shops closed by law",
"rule": "12-24",
"_weekday": "Thu"
},
Expand Down
12 changes: 6 additions & 6 deletions test/fixtures/DK-2021.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"date": "2021-01-01 00:00:00",
"start": "2020-12-31T23:00:00.000Z",
"end": "2021-01-01T23:00:00.000Z",
"name": "Nytår",
"name": "Nytårsdag",
"type": "public",
"rule": "01-01",
"_weekday": "Fri"
Expand Down Expand Up @@ -39,7 +39,7 @@
"date": "2021-04-04 00:00:00",
"start": "2021-04-03T22:00:00.000Z",
"end": "2021-04-04T22:00:00.000Z",
"name": "Påskesøndag",
"name": "Påskedag",
"type": "public",
"rule": "easter",
"_weekday": "Sun"
Expand Down Expand Up @@ -68,7 +68,7 @@
"end": "2021-05-01T22:00:00.000Z",
"name": "1. maj",
"type": "observance",
"note": "Full holiday for blue collar workers",
"note": "Not a public holiday; full day off for blue collar workers only",
"rule": "05-01",
"_weekday": "Sat"
},
Expand Down Expand Up @@ -114,17 +114,17 @@
"end": "2021-06-05T22:00:00.000Z",
"name": "Grundlovsdag",
"type": "observance",
"note": "Shops are closed",
"note": "Not a public holiday; shops closed by law",
"rule": "06-05",
"_weekday": "Sat"
},
{
"date": "2021-12-24 00:00:00",
"start": "2021-12-23T23:00:00.000Z",
"end": "2021-12-24T23:00:00.000Z",
"name": "Juleaften",
"name": "Juleaftensdag",
"type": "observance",
"note": "Shops are closed",
"note": "Not a public holiday; shops closed by law",
"rule": "12-24",
"_weekday": "Fri"
},
Expand Down
Loading