No Jira: Disable DTD when Parsing XML#540
Conversation
# Conflicts: # services/client/src/main/java/org/collectionspace/services/client/PoxPayload.java # services/common-http/src/main/java/org/collectionspace/services/common/provider/JakartaJAXBProvider.java
spirosdi
left a comment
There was a problem hiding this comment.
Looks good. Also tested locally and works as expected
|
Let us release the 8.3.1 without the #538 . Those changes are not really necessary for lyrasis hosted clients. Their dependency resolution is handled in a completely different way (through the plugin version map file) and they are already updated. Let us release the #538 as a next patch release mainly for self-hosted clients and demo/qa sites. Actually for the self hosted ones we only need to tag and release in github. I think this is also valid for demo/qa environments as they actually download the ui dependencies from github. In any case I think it is safer to release the #538 separately as it is not that high prio and it is better not to delay the current PR updates because of any #538 implications. |
What does this do?
This cherry picks commit 5ecf54a into main
Why are we doing this? (with JIRA link)
No jira. This disables the Doctype declaration on XML preventing external entities from being loaded.
How should this be tested? Do these changes have associated tests?
Dependencies for merging? Releasing to production?
This includes the version bump for 8.3.1 so maybe #538 should be merged first. We might also want to create a ticket for creating tests for this. Although the manual check is fine, something more comprehensive would probably be good.
Has the application documentation been updated for these changes?
No
Did someone actually run this code to verify it works?
@mikejritter tested locally
Have any new security vulnerabilities been handled?
This handles the same vuln from #535