fix(installer): preserve Codex TOML array tables#624
Open
chiehwangs wants to merge 1 commit into
Open
Conversation
Treat following [[array-of-tables]] headers as sibling boundaries when replacing or removing [mcp_servers.codegraph], so codegraph install and uninstall do not remove unrelated Codex configuration. Tests: - npx vitest run __tests__/installer-targets.test.ts - npm run build - full Vitest suite with fork workers using --liftoff-only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[[array-of-tables]]sections that follow the Codex MCP entryRoot cause
The Codex TOML helper located the end of
[mcp_servers.codegraph]by searching for the next table header, but intentionally skipped[[array-of-tables]]headers. When an array table followed the CodeGraph MCP entry, reinstalling or uninstalling CodeGraph treated that sibling configuration as part of the CodeGraph block and removed it.Validation
git diff --checknpx vitest run __tests__/installer-targets.test.tsnpm run build--liftoff-only: 52 test files passed, 1096 tests passed, 2 skippedNotes
On Node v24.15.0, plain
npm testreproduces the repository-documented V8 WASM TurboshaftFatal process out of memory: Zonefailure. Passing--liftoff-onlyto Vitest fork workers applies the existing runtime workaround and completes the full suite.