Skip to content

Add remove listener cleanup #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iamladi wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add remove listener cleanup #133

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61941ab
Add more debugging and fix event listner
iamladi Jun 2, 2023
717efcb
Remove unneded changes
iamladi Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/utils/CBPayInstance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,10 @@ export interface CBPayInstanceType {
export class CBPayInstance implements CBPayInstanceType {
private pixel: CoinbasePixel;
private options: InternalExperienceOptions;
private targetElement: HTMLElement | null;

constructor(options: CBPayInstanceConstructorArguments) {
this.targetElement = null;
this.options = options;
this.pixel = new CoinbasePixel({
...options,
Expand All @@ -40,9 +42,9 @@ export class CBPayInstance implements CBPayInstanceType {
});

if (options.target) {
const targetElement = document.querySelector(options.target);
if (targetElement) {
targetElement.addEventListener('click', this.open);
this.targetElement = document.querySelector(options.target);
if (this.targetElement) {
this.targetElement.addEventListener('click', this.open);
}
}
}
Expand Down Expand Up @@ -84,6 +86,9 @@ export class CBPayInstance implements CBPayInstanceType {
};

public destroy = (): void => {
if (this.targetElement) {
this.targetElement.removeEventListener('click', this.open);
}
this.pixel.destroy();
};
}