Make cdf_file_annotation and cdf_entity_matching self-contained#275
Make cdf_file_annotation and cdf_entity_matching self-contained#275Aashutosh-cognite wants to merge 1 commit into
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request aims to make the cdf_file_annotation and cdf_entity_matching modules self-contained by adding dedicated function spaces and updating their configurations. Feedback includes renaming the data_modeling directories to data_models to align with the repository style guide and correcting several inaccuracies and summation errors in the PRD.md resource summary table. Furthermore, the missing DataSet.yaml and Group.yaml definitions should be included to fulfill the self-containment goal.
7e0e65e to
7425757
Compare
352b917 to
f38c57f
Compare
7425757 to
a14c818
Compare
Depends on PR #274
Both contextualization modules previously relied on an external shared space (
springfield_functions) for storing CDF Function code nodes — a dependency oncdf_foundationwhich is being removed from the Foundation DP.This PR makes each module fully self-contained by:
fn.Space.yamlto each module that creates its own dedicated function space at deploy time.default.config.yamlto a module-scoped name (sp_file_annotation_fn / sp_entity_matching_fn) instead of the shared springfield_functions.PRD.mdto reflect the updated module status and revised resource counts.No functional changes — purely a self-containment fix so either module can be deployed independently without any other module having to pre-create the function space.