Skip to content

Make cdf_file_annotation and cdf_entity_matching self-contained#275

Open
Aashutosh-cognite wants to merge 1 commit into
foundational-dpfrom
foundational-dp-cleanup
Open

Make cdf_file_annotation and cdf_entity_matching self-contained#275
Aashutosh-cognite wants to merge 1 commit into
foundational-dpfrom
foundational-dp-cleanup

Conversation

@Aashutosh-cognite
Copy link
Copy Markdown
Contributor

@Aashutosh-cognite Aashutosh-cognite commented May 20, 2026

Depends on PR #274
Both contextualization modules previously relied on an external shared space (springfield_functions) for storing CDF Function code nodes — a dependency on cdf_foundation which is being removed from the Foundation DP.

This PR makes each module fully self-contained by:

  • Adding a fn.Space.yaml to each module that creates its own dedicated function space at deploy time.
  • Updating the functionSpace default in default.config.yaml to a module-scoped name (sp_file_annotation_fn / sp_entity_matching_fn) instead of the shared springfield_functions.
  • Updating PRD.md to reflect the updated module status and revised resource counts.

No functional changes — purely a self-containment fix so either module can be deployed independently without any other module having to pre-create the function space.

@gemini-code-assist
Copy link
Copy Markdown

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@Aashutosh-cognite Aashutosh-cognite changed the title cdf_common cleanup Make cdf_file_annotation and cdf_entity_matching self-contained May 20, 2026
@Aashutosh-cognite
Copy link
Copy Markdown
Contributor Author

/gemini review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to make the cdf_file_annotation and cdf_entity_matching modules self-contained by adding dedicated function spaces and updating their configurations. Feedback includes renaming the data_modeling directories to data_models to align with the repository style guide and correcting several inaccuracies and summation errors in the PRD.md resource summary table. Furthermore, the missing DataSet.yaml and Group.yaml definitions should be included to fulfill the self-containment goal.

Comment thread PRD.md Outdated
Comment thread PRD.md Outdated
@Aashutosh-cognite Aashutosh-cognite force-pushed the foundational-dp-cleanup branch from 7e0e65e to 7425757 Compare May 21, 2026 05:07
@Aashutosh-cognite Aashutosh-cognite requested a review from a team as a code owner May 22, 2026 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant