Repository navigation
Fix missing CVEs - #7
Merged
Merged
Conversation
|
🏷️ [bumpr] |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the RDJSON formatter and tests to handle yarn advisories that don’t include CVE identifiers by falling back to the advisory id and ensuring it’s emitted consistently.
Changes:
- Coerce the advisory CVE/id value to a string before writing it to
diagnostics[].code.value. - Add new test fixtures for an advisory with an empty
cvesarray. - Improve the test script by normalizing JSON before diffing and adding a regression test for the “no CVE” case.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
rdjson_formatter/rdjson_formatter.rb |
Ensures code.value is always string-typed when falling back to advisory id. |
test/rdjson_formatter/test.sh |
Adds JSON-normalized comparison and a new test path for advisories without CVEs. |
test/rdjson_formatter/testdata/advisory_without_cve.jsonl |
New JSONL input fixture representing an advisory without CVEs. |
test/rdjson_formatter/testdata/advisory_without_cve.ok |
New expected RDJSON output snapshot for the “no CVE” scenario. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
🚀 [bumpr] Bumped! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.