🤖 fix: settle child tasks when auto-retry abandons

[ammar-agent]

Summary

Unblock parent agents when a child sub-agent hits a stream error that never recovers via auto-retry, instead of leaving waitForAgentReport / workspace-turn waiters hanging until timeout.

Background

Child stream errors that schedule in-session auto-retry intentionally leave parent waiters blocked so a successful retry can complete the turn. Two failure modes left the parent blocked with no recovery path:

1. Retry scheduled, then abandoned — e.g. missing_retry_options or retry callback failure. TaskService only listened to stream error events, not auto-retry-abandoned chat events, so abandonment never settled the handle.
2. No recovery in flight — auto-retry disabled / immediately exhausted. Workspace-turn handles already settled in this case; agent tasks did not, so parents waited out the report timeout.

Implementation

• Cache the last stream error per child workspace so abandon settlement can surface the original error text.
• Listen for workspaceService chat → auto-retry-abandoned and terminally settle active workspace-turn handles and agent tasks (except disabled_by_user, which remains a steerable pause).
• For agent tasks still running, after waiting for the stream-error recovery decision, settle immediately when nothing is streaming/retrying (parity with workspace-turn handling). Keep aborted / context_exceeded non-terminal.
• Clear the cached stream error on stream-end and on terminal settlement.

Validation

• bun test src/node/services/taskService.test.ts -t "auto-retry abandoned|running tasks are NOT settled|running tasks settle immediately|model_refusal|awaiting_report tasks interrupt|workspace-turn auto-retry"
• make typecheck

Risks

• Medium: settlement timing around auto-retry races. Mitigated by waiting for the recovery decision, re-checking streaming/pending-retry under the workspace event lock, and excluding user-disabled retries and recoverable abort/context paths.

---

Generated with mux • Model: xai:grok-4.5 • Thinking: high

[ammar-agent]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9807881796

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[ammar-agent]

@codex review

Addressed the P2: stream-error allowlist is now an exhaustive Record<StreamErrorType, true> so schema additions fail typecheck instead of silently losing the original error on abandon settlement.

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: dfbc5893f7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".