-
Notifications
You must be signed in to change notification settings - Fork 127
🤖 fix: stop iPad taps from selecting the whole chat pane #3761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ibetitsmike
wants to merge
38
commits into
main
Choose a base branch
from
mike/ipad-chrome-text-selection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+15
−154
Open
Changes from 36 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
7270793
🤖 fix: stop iPad clicks on app chrome from selecting the chat pane
ibetitsmike 889066f
fix: scope the control selection rule to native buttons
ibetitsmike 20f5316
tests: pin the touch selection guard with a static contract
ibetitsmike 1a3a5e1
fix: drop the app-wide control selection rule
ibetitsmike 039334c
tests: reject media syntax the selection contract cannot model
ibetitsmike 18e9f15
tests: resolve the winning selection declaration
ibetitsmike 3808e37
tests: reject malformed media conditions in the selection contract
ibetitsmike e192e80
tests: reject selection rules that can defeat the inherited guard
ibetitsmike c922a79
tests: reject app-wide selection suppression on fine pointers
ibetitsmike c620444
tests: close remaining gaps in the selection contract
ibetitsmike a3f9df7
tests: match media queries and suppression selectors exactly
ibetitsmike cb80fa4
tests: track Tailwind selection opt-ins the stylesheet parse cannot see
ibetitsmike 830110c
tests: count selection opt-ins per file instead of listing files
ibetitsmike a3d54ef
tests: track arbitrary-property selection classes
ibetitsmike fc87ffe
tests: keep contract comments timeless
ibetitsmike bb03bc5
tests: count selection opt-ins in @source files too
ibetitsmike de0d186
tests: match every Tailwind selection spelling in the scans
ibetitsmike fdd2ec5
tests: match selection declarations case-insensitively
ibetitsmike ad1b031
tests: count inline selection styles as opt-ins
ibetitsmike 0d4b5f8
tests: match kebab selection strings in any case
ibetitsmike 80fe800
tests: pin each selection opt-in by its source line
ibetitsmike c9968b9
tests: pin selection opt-ins with the line that follows
ibetitsmike 7061817
tests: reject app-shell ids as suppression subjects
ibetitsmike 5282679
tests: track selection suppression sites like opt-ins
ibetitsmike 9e7a2eb
tests: let Tailwind's scanner decide which files to scan
ibetitsmike 9507186
tests: inventory selection tokens instead of snapshotting source
ibetitsmike e412a9b
tests: record the full Tailwind candidate in the inventory
ibetitsmike fc96d7e
test: require review for component-scoped selection suppression selec…
ibetitsmike cc47f44
test: inventory selection sites only in runtime renderer sources
ibetitsmike f6b3885
test: scan only renderer-reachable src segments for selection sites
ibetitsmike de06f58
test: exempt normal select-auto from the opt-in inventory
ibetitsmike 6dcaa31
test: ignore comments in selection inventories
ibetitsmike 580b3af
test: exclude Storybook helpers from selection inventory
ibetitsmike e155475
test: scan only executable renderer sources
ibetitsmike bfe66d1
test: parse runtime imports and cover vendor selection
ibetitsmike 0e215a0
fix: inventory explicit inline selection writes
ibetitsmike c63d7e5
test: inventory rendered selection sites
ibetitsmike 33ec94e
test: remove unbounded selection contract
ibetitsmike File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.