Repository navigation
Destroy the example's engine when its Activity finishes - #80
Merged
Merged
Conversation
The engine that survives the Android 12+ wallpaper relaunch was never destroyed, so after Back the next launch reused it as a warm start. Destroy it in onDestroy() unless the Activity is changing configurations, after super.onDestroy() has detached it. Document the same override in android-compatibility.md and note that FlutterFragmentActivity takes the same provideFlutterEngine override. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Activity relaunch after a wallpaper change" pattern keeps one
FlutterEngineacross the Android 12+ dynamic-color relaunch. It never destroyed that engine, so after the user pressed Back the next launch reused it as a warm start.MainActivityin the example now overridesonDestroy(). It destroys the engine and clears the reference when!isChangingConfigurations. A relaunch still keeps the engine.doc/android-compatibility.mdshows the same snippet. It explains thatsuper.onDestroy()must run first, because that call detaches the engine from the Activity and its plugins. It also notes thatFlutterFragmentActivitytakes the sameprovideFlutterEngineoverride.There are no plugin code changes.
Verification
06a2e2a):FlutterActivity.onDestroy()detaches the host-provided engine without destroying it.FlutterFragmentActivityhas a publicprovideFlutterEngine(Context), andFlutterFragmentdefers to it.MainActivity.ktwith Kotlin 2.2.20 and-Werroragainstandroid.jar(API 36) andflutter_embedding_debugfor that engine. No warnings.:appmodule, so CI covers assembly.🤖 Generated with Claude Code