Skip to content

bfix: Harden wallpaper persistence and native failure paths - #78

Merged
codenameakshay merged 1 commit into
mainfrom
t3code/rigorous-bug-hunt
Oct 6, 2026
Merged

codenameakshay merged 1 commit into
mainfrom
t3code/rigorous-bug-hunt

Conversation

@codenameakshay

Copy link
Copy Markdown
Owner

Interrupted rotation saves and video promotions could leave persisted settings paired with the wrong or missing files. This change makes those transitions recoverable, preserves committed outcomes when cleanup fails, and fixes additional input and platform defects found in the repository audit.

Fixes:

  • Write rotation playlists into immutable generations, synchronously commit their config pointer, and prune only after success. Preserve existing state and cache on failed commits.
  • Persist pending schedule changes with config/stop intent, recover current settings before stale-worker checks, and await WorkManager operations before clearing the marker. Commit stop before cancellations or cache deletion.
  • Open each video and its scale mode under one lock. Recover interrupted sidecar/video promotion through a journal; preserve successful promotion when only postcommit cleanup fails.
  • Normalize internationalized HTTPS hosts in both Android source loaders while retaining malformed-authority and port checks.
  • Reject nonportable shader counters and updates. Static loops now require integers within -255..255 and retain the 128-iteration cap.
  • Fall back to window-only EGL configs when pbuffer support is absent.
  • Use the Photos add-only operation on iOS 13, matching the documented usage key.
  • Remove three unused internal rotation accessors.

The audit ledger records each defect, coverage, rejected hypotheses, regression evidence, and review outcomes. New adversarial tests cover malformed URLs, reconstructed persistence state, injected filesystem/preference failures, and all 262,144 six-event video lifecycle sequences (1,572,864 transitions).

Validation:

  • Android: 124 tests across 19 suites; lint passed with 0 errors (8 advisory warnings).
  • Dart: 60 package tests, 10 example tests; analysis, formatting, and Pigeon freshness passed.
  • Swift transport: 15 tests passed.
  • Two complete GPT-6.1 Sol reviews: first-pass findings fixed and rechecked; independent second pass reported no findings.
  • Separate Luna standards/comments and spec checks completed; findings fixed.

CI must pass before this draft is marked ready. Local Android lint required an isolated SDK view excluding installed preview platforms with malformed ApiLevel=37.0 metadata; the shared SDK was not changed.

Local limits: Flutter 3.47.4 was available; CI uses pinned 3.41.4. The native harness compiles the real Android plugin. No local emulator/simulator is available, so GPU execution, iOS 13 permission prompts, real system preview/WorkManager behavior, and OEM-specific reports are not claimed verified. Process-death boundary tests do not prove sudden power-loss durability.

@codenameakshay
codenameakshay marked this pull request as ready for review October 6, 2026 11:11
@codenameakshay
codenameakshay merged commit 08933f1 into main Oct 6, 2026
6 checks passed
@codenameakshay
codenameakshay deleted the t3code/rigorous-bug-hunt branch October 6, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant