Repository navigation
bfix: harden wallpaper sources, rotation, and live assets - #77
Merged
Merged
Conversation
Bound downloads and image snapshots, preserve live wallpaper assets on failure, and fence rotation work across replacement and app upgrades. Add adversarial regressions and document the complete reliability audit.
Replace the file writer that requires iOS 13.4 with an output stream. Handle partial writes and write failures without raising the deployment target. Add regression coverage for these paths.
Locate XCTest through the selected Xcode SDK and use Darwin test discovery. Fail the runner when tests are missing, incomplete, or failing. Keep the Linux test entry point.
Add the Xcode platform Swift module and library directory to the macOS transport test runner. XCTest assertions require this path in addition to the Objective-C framework path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wallpaper requests could report the wrong target, leave resources open, or apply stale work after a playlist replacement. This change adds bounded source handling, serializes rotation transactions, and preserves active video/OpenGL assets across preparation failures.
The reliability audit documents all 19 bug groups, their fixes, regression coverage, reviewed areas, and device-testing limits.
Validation includes 60 package tests, 10 example tests, 15 Swift transport tests, 96 Android native tests and lint, Dart analysis/formatting, and Pigeon freshness. Permanent stress tests cover 350,400 calendar cases, 100,000 geometry cases, and 801 queue completions during concurrent shutdown. DST and MIME regressions also failed against the original production code.
Three independent GPT-6.1 Sol review passes checked the full diff; the final pass reported no findings. Review findings about Unicode hosts and migration of legacy alarms/workers received fixes and regression coverage. A separate Luna standards review found no documented-standard violations.
Local Flutter is 3.47.4; CI passed with pinned Flutter 3.41.4, the Android example build, and the iOS simulator build. No local emulator or simulator was available, so physical GPU, Photos, preview confirmation, and OEM target behavior remain unverified. Existing OEM reports are not claimed fixed.
All CI checks passed on
08adf15: Dart quality, Android tests, lint, and build, and iOS build and transport tests. CI monitoring remains active. Do not merge automatically.The iOS transport uses OutputStream with partial-write/error coverage and preserves iOS 13.0 support. The portable runner locates the macOS XCTest framework and Swift modules. Additional focused Sol reviews covered these changes.