Skip to content

bfix: harden wallpaper sources, rotation, and live assets - #77

Merged
codenameakshay merged 4 commits into
mainfrom
t3code/rigorous-bug-hunting
Oct 6, 2026
Merged

codenameakshay merged 4 commits into
mainfrom
t3code/rigorous-bug-hunting

Conversation

@codenameakshay

@codenameakshay codenameakshay commented Oct 4, 2026 •

Copy link
Copy Markdown
Owner

Wallpaper requests could report the wrong target, leave resources open, or apply stale work after a playlist replacement. This change adds bounded source handling, serializes rotation transactions, and preserves active video/OpenGL assets across preparation failures.

The reliability audit documents all 19 bug groups, their fixes, regression coverage, reviewed areas, and device-testing limits.

  • Dart: verify the requested target in host replies; reject interval overflow and malformed HTTPS input while preserving Unicode hostnames; avoid redundant byte-buffer copies.
  • Downloads and image sources: stream iOS downloads into bounded temporary files; reject HTTP errors; close Android responses on allocation failure; reject conflicting decoded MIME types; use one bounded source snapshot for image decoding; count skipped bytes against source limits.
  • Rotation: serialize lifecycle transactions; validate native input before narrowing; fix DST and exact-boundary scheduling; reconcile clock changes; reset replacement cadence; fence stale and legacy workers/alarms by generation; reject failed JPEG encoding.
  • Live wallpapers: preserve active video during failed promotion; stage OpenGL input before the final Activity check; retain texture generations used by existing renderers.
  • Remove the separate rotation executor and unused internal scheduling/cursor paths. Add the portable Swift transport suite to CI.

Validation includes 60 package tests, 10 example tests, 15 Swift transport tests, 96 Android native tests and lint, Dart analysis/formatting, and Pigeon freshness. Permanent stress tests cover 350,400 calendar cases, 100,000 geometry cases, and 801 queue completions during concurrent shutdown. DST and MIME regressions also failed against the original production code.

Three independent GPT-6.1 Sol review passes checked the full diff; the final pass reported no findings. Review findings about Unicode hosts and migration of legacy alarms/workers received fixes and regression coverage. A separate Luna standards review found no documented-standard violations.

Local Flutter is 3.47.4; CI passed with pinned Flutter 3.41.4, the Android example build, and the iOS simulator build. No local emulator or simulator was available, so physical GPU, Photos, preview confirmation, and OEM target behavior remain unverified. Existing OEM reports are not claimed fixed.

All CI checks passed on 08adf15: Dart quality, Android tests, lint, and build, and iOS build and transport tests. CI monitoring remains active. Do not merge automatically.

The iOS transport uses OutputStream with partial-write/error coverage and preserves iOS 13.0 support. The portable runner locates the macOS XCTest framework and Swift modules. Additional focused Sol reviews covered these changes.

Bound downloads and image snapshots, preserve live wallpaper assets on
failure, and fence rotation work across replacement and app upgrades.

Add adversarial regressions and document the complete reliability audit.
Replace the file writer that requires iOS 13.4 with an output stream.
Handle partial writes and write failures without raising the deployment
target. Add regression coverage for these paths.
Locate XCTest through the selected Xcode SDK and use Darwin test
discovery. Fail the runner when tests are missing, incomplete, or failing.
Keep the Linux test entry point.
Add the Xcode platform Swift module and library directory to the macOS
transport test runner. XCTest assertions require this path in addition
to the Objective-C framework path.
@codenameakshay
codenameakshay marked this pull request as ready for review October 4, 2026 18:08
@codenameakshay
codenameakshay merged commit 4b7cba7 into main Oct 6, 2026
6 checks passed
@codenameakshay
codenameakshay deleted the t3code/rigorous-bug-hunting branch October 6, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant