Skip to content

Fix: team members editor screen #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NathanWEdwards wants to merge 2 commits into
base: production
Choose a base branch
from
Open

Fix: team members editor screen #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b89accd
fix: modal bounds issue pushes the ButtonBar and FlatList out of view…
NathanWEdwards Apr 6, 2026
6b245c6
fix: recalculate bounds for views in modals with SafeAreaProvider.
NathanWEdwards Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions components/team-members-editor/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
View,
FlatList
} from "react-native";
import { SafeAreaView } from "react-native-safe-area-context";
import { SafeAreaView, SafeAreaProvider } from "react-native-safe-area-context";
import { connect } from "react-redux";
import MemberIcon from "../../components/member-icon";
import { defaultStyles } from "../../styles/default-styles";
Expand Down Expand Up @@ -171,22 +171,26 @@ const TeamMembersEditor = ({ actions, team, members, requests, invitations }: Pr


return (
<SafeAreaView style={ styles.frame }>
<ButtonBar buttonConfigs={ headerButtons }/>
<View style={ {
flex: 1,
backgroundColor: constants.colorBackgroundLight
} }>
<FlatList data={memberRowData} renderItem={ ({item}) => (<MemberItem item={item} />)} />
</View>
<View style={ { flex: 1 } }>
<SafeAreaView style={ { backgroundColor: constants.colorBackgroundDark, flex: 1 } }>
<ButtonBar buttonConfigs={ headerButtons }/>
<View style={ {
flex: 1,
backgroundColor: constants.colorBackgroundLight
} }>
<FlatList data={memberRowData} renderItem={ ({item}) => (<MemberItem item={item} />)} />
</View>
</SafeAreaView>
<Modal
animationType={ "slide" }
onRequestClose={ (): string => ("this function is required. Who knows why?") }
transparent={ false }
transparent={ true }
visible={ isModalVisible }>
{ modalContent }
<SafeAreaProvider>
{ modalContent }
</SafeAreaProvider>
</Modal>
</SafeAreaView>
</View>
);
};

Expand Down