Skip to content

⚡️ Speed up function isValidTimespan by 32% #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

⚡️ Speed up function isValidTimespan by 32% #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions apps/meteor/client/lib/convertTimeUnit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,18 @@ export enum TIMEUNIT {
}

export const isValidTimespan = (timespan: number): boolean => {
if (Number.isNaN(timespan)) {
// Fast-path type check to preserve original Number.isFinite behavior for non-number inputs
if (typeof timespan !== 'number') {
return false;
}

if (!Number.isFinite(timespan)) {
// NaN check without calling Number.isNaN
if (timespan !== timespan) {
return false;
}

// Infinity checks without calling Number.isFinite
if (timespan === Infinity || timespan === -Infinity) {
return false;
}

Expand Down