fix(cursor-cli-oauth): keep tool protocol out of assistant text - #1107
Open
eddieparc wants to merge 2 commits into
Open
fix(cursor-cli-oauth): keep tool protocol out of assistant text#1107eddieparc wants to merge 2 commits into
eddieparc wants to merge 2 commits into
Conversation
Keep Cursor-executed tool protocol out of assistant text and host tool calls, with regression coverage and provider documentation. OmO issue: code-yeongyu/oh-my-openagent#7169 Ultraworked with [omo](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: sisyphus-dev-ai <sisyphus-dev-ai@users.noreply.github.com>
Resolve the concurrent release changelog while preserving the Cursor provider fix. Ultraworked with [omo](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: sisyphus-dev-ai <sisyphus-dev-ai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool_callprotocol into assistant texttoolCallblocks so Senpi cannot execute them a second timeUser-facing OmO issue: code-yeongyu/oh-my-openagent#7169
Root cause
renderToolFrame()serialized Cursor started and completed tool events, including arguments and results, into<cursor-cli-tool>strings.appendToolFrame()sent those strings throughpushTextDelta(), so consumers persisted and rendered provider-internal JSON as assistant prose.Cursor already executed these tools in its subprocess. Suppressing the protocol frames at the provider boundary avoids both conversation-context contamination and duplicate host-side execution.
Validation
npm run check: passednpm run build: passed22and emitted no<cursor-cli-tool>or serialized tool JSON in visible outputSummary by cubic
Prevents leaking Cursor CLI tool protocol into assistant text and avoids duplicate host execution for
cursor-cli-oauth. Previously we serializedtool_callevents into<cursor-cli-tool>strings and sent them via text deltas; now we suppress those events and store/render only model prose.tool_callevents are ignored; Cursor executes tools in its subprocess; no hosttoolCallblocks emit.<cursor-cli-tool>tags or provider JSON in deltas or persisted messages; only the assistant’s final prose remains.stream.test.ts;AGENTS.md,changes.md, andCHANGELOG.mddocument the behavior and resolve the concurrent release entry.<cursor-cli-tool>assistant text, remove that logic—these frames no longer emit.Written for commit 29ed15f. Summary will update on new commits.