Skip to content

Bugfix #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prandla merged 6 commits into from
Apr 23, 2026
+37 −13
Merged

Bugfix #1685

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
436c8c6
Prevent open redirect in login 'next' handling
pxsit Apr 22, 2026
f287c31
Merge branch 'cms-dev:main' into bugfix
pxsit Apr 22, 2026
2c83bef
Update cms/server/contest/handlers/main.py
pxsit Apr 22, 2026
46800cd
Validate and sanitize 'next' URL in login handlers
pxsit Apr 22, 2026
80bf1fe
Move function to util.py
pxsit Apr 23, 2026
41aa0c9
Merge branch 'main' into bugfix
pxsit Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions cms/server/admin/handlers/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

import json
import logging
from urllib.parse import urlsplit

from cms import ServiceCoord, get_service_shards, get_service_address
from cms.db import Admin, Contest, Question
Expand All @@ -48,8 +49,13 @@ def post(self):
next_page: str = self.get_argument("next", None)
Comment thread
pxsit marked this conversation as resolved.
if next_page is not None:
error_args["next"] = next_page
if next_page != "/":
next_page = self.url(*next_page.strip("/").split("/"))
split = urlsplit(next_page)
if split.scheme or split.netloc or not split.path.startswith("/"):
next_page = self.url()
elif split.path != "/":
next_page = self.url(*split.path.strip("/").split("/"))
if split.query:
next_page += "?" + split.query
else:
next_page = self.url()
Comment thread
pxsit marked this conversation as resolved.
Outdated
else:
Expand Down
10 changes: 8 additions & 2 deletions cms/server/contest/handlers/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import logging
import os.path
import re
from urllib.parse import urlsplit

import collections

Expand Down Expand Up @@ -217,8 +218,13 @@ def post(self):
next_page: str | None = self.get_argument("next", None)
if next_page is not None:
error_args["next"] = next_page
if next_page != "/":
next_page = self.url(*next_page.strip("/").split("/"))
split = urlsplit(next_page)
if split.scheme or split.netloc or not split.path.startswith("/"):
next_page = self.contest_url()
elif split.path != "/":
next_page = self.url(*split.path.strip("/").split("/"))
if split.query:
next_page += "?" + split.query
Comment thread
pxsit marked this conversation as resolved.
Outdated
else:
next_page = self.url()
else:
Expand Down
Loading