fix(langfuse): fix latency display showing incorrect huge hours value#688
Open
favbox wants to merge 2 commits intocloudwego:mainfrom
Open
fix(langfuse): fix latency display showing incorrect huge hours value#688favbox wants to merge 2 commits intocloudwego:mainfrom
favbox wants to merge 2 commits intocloudwego:mainfrom
Conversation
## Problem
Langfuse UI was displaying incorrect latency values like "17751749h"
instead of the actual duration in milliseconds (e.g., "854ms").
## Root Cause
The callback handler was not preserving the original `startTime` when
updating spans/generations in `OnEnd`. This caused the `startTime` to be
reset to zero value ("0001-01-01T00:00:00Z"), which Langfuse backend
uses to calculate latency as `endTime - startTime`, resulting in a
massive time difference.
## Solution
1. Add `Duration` field (milliseconds) to `SpanEventBody` and
`GenerationEventBody` in event data model
2. Store `startTime` in callback state during `OnStart`
3. Preserve original `startTime` and calculate `duration` in `OnEnd`
## Changes
- `libs/acl/langfuse/event.go`: Add `Duration *int64` field
- `callbacks/langfuse/langfuse.go`: Track startTime and compute duration
- `callbacks/langfuse/go.mod`: Add local replace for development
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
|
shentongmartin
added
C-enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Langfuse UI was displaying incorrect latency values like "17751749h 37m 57s"
instead of the actual duration in milliseconds (e.g., "854ms").
Root Cause
The callback handler was not preserving the original
startTimewhenupdating spans/generations in
OnEnd. This caused thestartTimeto bereset to zero value (
"0001-01-01T00:00:00Z"), which Langfuse backenduses to calculate latency as
endTime - startTime, resulting in amassive time difference.
Solution
Durationfield (milliseconds) toSpanEventBodyandGenerationEventBodyin event data modelstartTimein callback state duringOnStartstartTimeand calculatedurationinOnEndChanges
libs/acl/langfuse/event.go: AddDuration *int64field (milliseconds)callbacks/langfuse/langfuse.go: Track startTime and compute durationTesting
Before fix:
Latency: 17751749h 37m 57s❌After fix:
Latency: 854ms✅Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com