Skip to content

feat(authz): add shoot-grafter group to authz RBAC and matchConditions #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Zaggy21 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Draft

feat(authz): add shoot-grafter group to authz RBAC and matchConditions #2129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/authz/templates/rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ metadata:
{{- . | nindent 4 }}
{{- end }}
rules:
- apiGroups: ["greenhouse.sap"]
- apiGroups: ["greenhouse.sap", "shoot-grafter.cloudoperators.dev"]
resources: ["*"]
verbs: ["get", "list", "watch"]
- apiGroups: [""]
Expand Down
2 changes: 1 addition & 1 deletion dev-env/webhook/structured-authz-insecure.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ authorizers:
matchConditions:
- expression: has(request.resourceAttributes) # only resource requests
- expression: request.resourceAttributes.namespace != ""
- expression: request.resourceAttributes.group == "greenhouse.sap"
- expression: request.resourceAttributes.group in ["greenhouse.sap", "shoot-grafter.cloudoperators.dev"]
# Note on verbs: get is needed for kubectl edit; watch is still needed for kubectl wait triggered after kubectl delete.
# List is intentionally not matched here and should be handled via RBAC instead.
- expression: request.resourceAttributes.verb in ["get","watch","update","patch","delete"]
Expand Down
2 changes: 1 addition & 1 deletion dev-env/webhook/structured-authz-secure.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ authorizers:
matchConditions:
- expression: has(request.resourceAttributes) # only resource requests
- expression: request.resourceAttributes.namespace != ""
- expression: request.resourceAttributes.group == "greenhouse.sap"
- expression: request.resourceAttributes.group in ["greenhouse.sap", "shoot-grafter.cloudoperators.dev"]
# Note on verbs: get is needed for kubectl edit; watch is still needed for kubectl wait triggered after kubectl delete.
# List is intentionally not matched here and should be handled via RBAC instead.
- expression: request.resourceAttributes.verb in ["get","watch","update","patch","delete"]
Expand Down
Loading