Fix bean field naming conflict in SpringServletXmlBeansConfiguration#3836
Open
mortenrie wants to merge 1 commit intocloudfoundry:developfrom
Open
Fix bean field naming conflict in SpringServletXmlBeansConfiguration#3836mortenrie wants to merge 1 commit intocloudfoundry:developfrom
mortenrie wants to merge 1 commit intocloudfoundry:developfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In SpringServletXmlBeansConfiguration, two @Autowired fields had the same names as the @bean methods they were used in:
This naming conflict is flagged by SonarQube as a code smell, since the field name shadows the method name within the same class, which can cause confusion and potential Spring wiring issues.
The fix renames the two injected fields to globalClientSecretPolicyConfig and defaultClientSecretPolicyConfig respectively, making them clearly distinct from the @bean factory methods and resolving the Sonar warning.