Add acked packet count to connection stats to make short-term loss rate more precisely#2440
Open
xxoo wants to merge 10 commits into
Open
Add acked packet count to connection stats to make short-term loss rate more precisely#2440xxoo wants to merge 10 commits into
acked packet count to connection stats to make short-term loss rate more precisely#2440xxoo wants to merge 10 commits into
Conversation
…rate more precisely
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ad3d1845f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Using
lost / sentfor short-term loss estimation is misleading becausesentincludes a significant share of packets that are still in flight.For immediate control decisions, this inflates the denominator and underestimates actual loss.
This change uses resolved outcomes instead:
lost / (acked + lost)or(lost - spurious_lost) / (acked + lost).What changed
acked(number of acknowledged packets) toquiche::Stats.acked_packetsand propagated it to connection-level stats.ackedto C FFIquiche_statsand populated it inquiche_conn_stats().apps/quiche-serverloss-rate calculation fromlost / senttolost / (acked + lost), with zero-denominator protection.stats().acked.Compatibility
quiche::Statshas a new public field (acked).quiche_statslayout now includesacked.Validation
cargo test --all-targets --features=async,ffi,qlog --workspacecargo test --doc --features=async,ffi,qlog --workspace