Skip to content

fix(ci): drop nc31; add nc34 #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oleksandr-nc wants to merge 5 commits into
base: main
Choose a base branch
from
+56 −11
Open

fix(ci): drop nc31; add nc34 #449

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b44d29a
ci: drop Nextcloud 31 and add Nextcloud 34 to the test matrix
oleksandr-nc Jul 7, 2026
679eb63
test(teams): xfail local-circle creation pending upstream Circles fix
oleksandr-nc Jul 7, 2026
3336382
fix(ci): unblock the stable34 jobs
oleksandr-nc Jul 7, 2026
643b1e6
test(teams): scope the local-circle xfail to NextcloudException
oleksandr-nc Jul 7, 2026
9cf12d3
fix(talk): persist bot secret for other workers on AppAPI 34
oleksandr-nc Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/analysis-coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ env:
APP_PORT: 9009
NC_AUTH_USER: "admin"
NC_AUTH_PASS: "adminpassword"
NEXTCLOUD_BRANCH: stable31
NEXTCLOUD_BRANCH: stable34

jobs:
analysis:
Expand All @@ -42,7 +42,7 @@ jobs:
tests-oci:
needs: [analysis]
runs-on: ubuntu-22.04
name: stable31 • 🐍3.11 • OCI
name: stable34 • 🐍3.11 • OCI
timeout-minutes: 60

services:
Expand Down Expand Up @@ -204,7 +204,7 @@ jobs:
with:
repository: nextcloud/notes
# Notes main (v5.0.0) requires NC >= 33; pin older servers to the last 4.x (supports NC 28-34).
ref: "${{ (matrix.nextcloud == 'stable31' || matrix.nextcloud == 'stable32') && 'v4.13.1' || 'main' }}"
ref: "${{ matrix.nextcloud == 'stable32' && 'v4.13.1' || 'main' }}"
path: apps/notes

- name: Checkout Files Locking
Expand Down Expand Up @@ -338,7 +338,7 @@ jobs:
strategy:
fail-fast: false
matrix:
nextcloud: [ 'stable31', 'stable32' ]
nextcloud: [ 'stable32', 'stable34' ]
Comment thread
oleksandr-nc marked this conversation as resolved.
env:
NC_dbname: nextcloud_abz
DATABASE_PGSQL: 1
Expand Down Expand Up @@ -515,7 +515,7 @@ jobs:
strategy:
fail-fast: false
matrix:
nextcloud: [ 'stable31', 'stable33' ]
nextcloud: [ 'stable33', 'stable34' ]
Comment thread
oleksandr-nc marked this conversation as resolved.
env:
NEXTCLOUD_URL: "http://localhost:8080/index.php"
timeout-minutes: 60
Expand Down Expand Up @@ -550,7 +550,7 @@ jobs:
with:
repository: nextcloud/notes
# Notes main (v5.0.0) requires NC >= 33; pin older servers to the last 4.x (supports NC 28-34).
ref: "${{ (matrix.nextcloud == 'stable31' || matrix.nextcloud == 'stable32') && 'v4.13.1' || 'main' }}"
ref: "${{ matrix.nextcloud == 'stable32' && 'v4.13.1' || 'main' }}"
path: apps/notes

- name: Checkout Files Locking
Expand Down
6 changes: 6 additions & 0 deletions tests/actual_tests/teams_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,12 @@ async def test_teams_personal_circle(anc_any):


@pytest.mark.asyncio(scope="session")
@pytest.mark.xfail(
reason="Upstream Circles regression: creating a local circle through an ExApp (app mode) returns HTTP 400 "
"since the nextcloud/circles local-controller permission changes (mid-2026). Client mode is unaffected. "
"Remove this marker once Circles is fixed on the stable branches.",
strict=False,
)
Comment thread
coderabbitai[bot] marked this conversation as resolved.
async def test_teams_local_circle(anc_any):
if await anc_any.teams.available is False:
pytest.skip("Teams (Circles) is not installed")
Expand Down
Loading