fix(complete): Update Elvish registration to modern syntax#6259
Open
AndreasBackx wants to merge 1 commit intoclap-rs:masterfrom
Open
fix(complete): Update Elvish registration to modern syntax#6259AndreasBackx wants to merge 1 commit intoclap-rs:masterfrom
AndreasBackx wants to merge 1 commit intoclap-rs:masterfrom
Conversation
AndreasBackx
changed the title
Replace the deprecated `env VAR=value command` pattern with the `tmp E:VAR = value` syntax for setting temporary environment variables in Elvish completion registration scripts. The `env` command was removed in Elvish 0.21, while `tmp` has been available since Elvish 0.18.
AndreasBackx
force-pushed
the
fix/elvish-deprecated-syntax
branch
from
de682af to
5791dcd
Compare
Member
|
This does not address the points discussed in #5729 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5729
Summary
Updates the Elvish dynamic completion registration script to use
tmp E:VAR = valueinstead of the deprecatedenv VAR=value commandpattern. The old syntax was deprecated in Elvish 0.18 and removed entirely in 0.21.Changes
clap_complete/src/env/shells.rs: The Elvishwrite_registrationtemplate now usestmp E:for temporary environment variables. Thetmpcommand automatically restores previous values when the enclosing lambda returns.No dedicated unit test was added because the existing integration tests in
elvish.rslreadyvalidate the Elvish completion flow end-to-end through completest_pty::ElvishRuntimeBuilder`.
Test plan
cargo test -p clap_complete --features unstable-dynamic— all 107 tests passcargo clippy -p clap_complete --features unstable-dynamic— clean