feat: implement fiber wasm demo#367
Conversation
ashuralyk
commented
Apr 16, 2026
- I have read the Contributing Guidelines
✅ Deploy Preview for docsccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for apiccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for liveccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
✅ Deploy Preview for appccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Code Review
This pull request adds a Fiber node demo for managing in-browser nodes, peers, and payments. Feedback focuses on narrowing security header scope to maintain wallet compatibility, fixing signature byte conversion for key derivation, and replacing floating-point math with fixed-point utilities to ensure precision for CKB amounts.
| async headers() { | ||
| return [ | ||
| { | ||
| source: "/(.*)", |
There was a problem hiding this comment.
The source pattern /(.*) applies the COOP and COEP headers to all routes. However, the comments on lines 9-12 state that these headers should only be applied to /connected/Fiber because they break cross-origin wallet popups (like JoyID) used on other pages. Applying these headers globally will break wallet functionality for the rest of the application, including the /fiber-sign-proxy mentioned in the comments.
| source: "/(.*)", | |
| source: "/connected/Fiber", |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
