Allow TOKEN_FILE to specifiy a token instead of using TOKEN#15
Open
CodeLongAndProsper90 wants to merge 1 commit into
Open
Allow TOKEN_FILE to specifiy a token instead of using TOKEN#15CodeLongAndProsper90 wants to merge 1 commit into
CodeLongAndProsper90 wants to merge 1 commit into
Conversation
cjdenio
reviewed
Apr 15, 2022
| if read_result.is_err() { | ||
| return Outcome::Failure((Status::Unauthorized, String::from("Invalid API token."))); | ||
| } | ||
| read_result.expect("") |
Owner
There was a problem hiding this comment.
Ideally this condition wouldn't cause the app to crash
Author
There was a problem hiding this comment.
It wouldn't, because we already checked is_err().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets you specify a file
TOKEN_FILE, from which the contents are read.TOKENtakes precedence over this. The main use case for this, right now, is a NixOS module I'm writing (it'd be bad to leave the token in a flake).