Repository navigation
CRASM-4295: Add WhoisXML Reverse DNS Cache Table Model - #1661
Merged
Merged
Conversation
arng4108
marked this pull request as ready for review
October 15, 2026 20:31
arng4108
requested review from
ameliav,
cduhn17,
hawkishpolicy,
jayjaybunce,
nickviola,
rapidray12 and
schmelz21
as code owners
October 15, 2026 20:31
jayjaybunce
approved these changes
Oct 16, 2026
ameliav
approved these changes
Oct 16, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
Add models.py model for the table "whoisxml_reverse_dns_cache" that's been created in the P&E database. This model will allow for future caching solution implementations to query the cache table via the P&E API
💭 Motivation and context
We need to create a corresponding model in models.py for the whoisxml_reverse_dns_cache table in the P&E database so that the whoisxml caching solution script and ASM Sync script are able to query the cache table using the P&E API
🧪 Testing
Tested locally by adding model to models.py and running Makefile build/start/syncdb-populate and confirming that the resulting table that is set up locally matches the real table in the PE database. Also verified that table name, column names, data types, and constraints match as well.
✅ Pre-approval checklist
bump_versionscript if this repository is versioned and the changes in this PR warrant a version bump.✅ Pre-merge checklist
✅ Post-merge checklist