Skip to content

CRASM-4295: Add WhoisXML Reverse DNS Cache Table Model - #1661

Merged
rapidray12 merged 1 commit into
developfrom
CRASM4295-WhoisXML-Cache-Table
Oct 16, 2026
Merged

rapidray12 merged 1 commit into
developfrom
CRASM4295-WhoisXML-Cache-Table

Conversation

@arng4108

Copy link
Copy Markdown
Contributor

🗣 Description

Add models.py model for the table "whoisxml_reverse_dns_cache" that's been created in the P&E database. This model will allow for future caching solution implementations to query the cache table via the P&E API

💭 Motivation and context

We need to create a corresponding model in models.py for the whoisxml_reverse_dns_cache table in the P&E database so that the whoisxml caching solution script and ASM Sync script are able to query the cache table using the P&E API

🧪 Testing

Tested locally by adding model to models.py and running Makefile build/start/syncdb-populate and confirming that the resulting table that is set up locally matches the real table in the PE database. Also verified that table name, column names, data types, and constraints match as well.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • AI was used for research and/or understanding purposes while creating this pull request.
  • AI was used to generate code in this PR (either fully or in part).
    • I attest that I understand the AI-generated code and its functionality.
    • I am comfortable answering questions about the implementation of the AI-generated code.
  • All new and existing tests pass.
  • Bump major, minor, patch, pre-release, and/or build versions as appropriate via the bump_version script if this repository is versioned and the changes in this PR warrant a version bump.
  • Create a pre-release (necessary if and only if the pre-release version was bumped).

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release (necessary if and only if the version was bumped).

@rapidray12
rapidray12 merged commit 52d8999 into develop Oct 16, 2026
23 of 24 checks passed
@rapidray12
rapidray12 deleted the CRASM4295-WhoisXML-Cache-Table branch October 16, 2026 14:43

This branch was previously deployed

1 inactive deployment
staging — bbda49e2 Deployed Oct 15, 2026 by arng4108 via test #3436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants