Skip to content

4324 Update was-reporting.tf with lifecycle enabled - #1641

Merged
rapidray12 merged 2 commits into
developfrom
cd_WAS_EC2_updateLC
Oct 9, 2026
Merged

4324 Update was-reporting.tf with lifecycle enabled#1641
rapidray12 merged 2 commits into
developfrom
cd_WAS_EC2_updateLC

Conversation

@cduhn17

@cduhn17 cduhn17 commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

🗣 Description

Reenable lifecycle at terraform

💭 Motivation and context

The terrafrom lifecycle must be reenabled to prevent destruction when new PR are merged.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • AI was used for research and/or understanding purposes while creating this pull request.
  • AI was used to generate code in this PR (either fully or in part).
    • I attest that I understand the AI-generated code and its functionality.
    • I am comfortable answering questions about the implementation of the AI-generated code.
  • All new and existing tests pass.
  • Bump major, minor, patch, pre-release, and/or build versions as appropriate via the bump_version script if this repository is versioned and the changes in this PR warrant a version bump.
  • Create a pre-release (necessary if and only if the pre-release version was bumped).

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release (necessary if and only if the version was bumped).

@cduhn17
cduhn17 marked this pull request as ready for review October 9, 2026 17:33
@cduhn17
cduhn17 deployed to integration October 9, 2026 17:33 — with GitHub Actions Active
jayjaybunce
jayjaybunce previously approved these changes Oct 9, 2026
View reviewed changes
rapidray12
rapidray12 previously approved these changes Oct 9, 2026
View reviewed changes

@rapidray12 rapidray12 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough LGTM

@jayjaybunce jayjaybunce changed the title Update was-reporting.tf with lifecycle enabled 4324 Update was-reporting.tf with lifecycle enabled Oct 9, 2026
@cduhn17
cduhn17 dismissed stale reviews from rapidray12 and jayjaybunce via 1aa6369 October 9, 2026 17:44
@cduhn17
cduhn17 deployed to integration October 9, 2026 17:44 — with GitHub Actions Active
rapidray12
rapidray12 reviewed Oct 9, 2026
View reviewed changes

@rapidray12 rapidray12 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rapidray12
rapidray12 self-requested a review October 9, 2026 17:48
rapidray12
rapidray12 approved these changes Oct 9, 2026
View reviewed changes

@rapidray12 rapidray12 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rapidray12
rapidray12 merged commit 1bc1dc6 into develop Oct 9, 2026
19 of 23 checks passed
@rapidray12
rapidray12 deleted the cd_WAS_EC2_updateLC branch October 9, 2026 17:50

This branch was successfully deployed

1 active deployment
staging — 1aa63698 Deployed Oct 9, 2026 by cduhn17 via staging #1024
integration — 1aa63698 Deployed Oct 9, 2026 by cduhn17 via integration #1024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jayjaybunce jayjaybunce jayjaybunce approved these changes
@rapidray12 rapidray12 rapidray12 approved these changes
@nickviola nickviola Awaiting requested review from nickviola nickviola is a code owner
@schmelz21 schmelz21 Awaiting requested review from schmelz21 schmelz21 is a code owner
@hawkishpolicy hawkishpolicy Awaiting requested review from hawkishpolicy hawkishpolicy is a code owner
@ameliav ameliav Awaiting requested review from ameliav ameliav is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cduhn17 @jayjaybunce @rapidray12