Skip to content

4294 - Set create_cti_instance to false for stage-cd - #1631

Merged
nickviola merged 1 commit into
developfrom
jb-crasm-4294-terminate-stage-cd-opencti
Oct 1, 2026
Merged

nickviola merged 1 commit into
developfrom
jb-crasm-4294-terminate-stage-cd-opencti

Conversation

@jayjaybunce

Copy link
Copy Markdown
Contributor

🗣 Description

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.
  • Bump major, minor, patch, pre-release, and/or build versions as appropriate via the bump_version script if this repository is versioned and the changes in this PR warrant a version bump.
  • Create a pre-release (necessary if and only if the pre-release version was bumped).

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release (necessary if and only if the version was bumped).

@rapidray12 rapidray12 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be the smallest PR i have ever reviewed. I did look thru the rest of the Terraform code to see what this affected. We are good on all fronts

@nickviola nickviola left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickviola
nickviola merged commit f33ba4b into develop Oct 1, 2026
16 of 17 checks passed
@nickviola
nickviola deleted the jb-crasm-4294-terminate-stage-cd-opencti branch October 1, 2026 17:11

This branch was successfully deployed

1 active and 1 inactive deployments
integration — 1cb9e2a6 Deployed Oct 1, 2026 by jayjaybunce via integration #1012
staging — 1cb9e2a6 Deployed Oct 1, 2026 by jayjaybunce via staging #1012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants