Repository navigation
Conversation
There was a problem hiding this comment.
Disclosure: I'm not affiliated with Circle — an external community contributor, not a maintainer. I have no write access to this repository, so any review state I set (approval or change request) carries no merge authority and is advisory only. Please treat this as one contributor's technical assessment, and defer to Circle maintainers for the binding review.
Verified against the source and this checks out completely:
- The spammer writes
tx_latency_{}.csvwithchrono::Utc::now().format("%Y%m%d_%H%M%S")— and it does so at both construction sites inspammer.rs(~line 164 and ~511), so the underscore/timestamp format is the only format the binary can ever produce. The oldtx-latency-1234567890.csvexamples (hyphens + what looks like a unix epoch) match neither the separator nor the timestamp scheme — likely a leftover from an earlier iteration of the tracker. - Nice touch reusing
tx_latency_20260310_151123.csvverbatim from the README's own "Output" section (line ~438): the doc now shows one consistent example filename from generation through analysis, so a reader can literally trace the same file across sections. - The remaining
data.csvplaceholders in the subcommand examples are correctly left alone — those are deliberately generic, andtx_latency_report.pytakes whatever--csvpath it's given (no filename-pattern assumptions in the script), so nothing else in that section needed touching.
Small observation on why this survived: the stale examples were internally consistent (all three identical), which is exactly the kind of wrong-but-coherent doc that passes casual review. The fix inherits the doc's real defense — the example now derives from the format string the code uses, so a future rename of the CSV pattern will at least have a greppable tx_latency_ prefix linking code and README.
Approving — three-line docs fix, verified against both code paths that write the file.
|
Hi @UfukNode, Thank you for your interest in contributing to Arc Node, and apologies for the delay in getting back to this PR. We're closing out the pull request backlog that predates our current contribution policy. This PR is being closed because it does not reference a GitHub issue. All PRs must reference an existing issue using the format This is not a judgement on the change itself. If you'd still like to land it:
Please see CONTRIBUTING.md for details. Thanks again for taking the time to contribute. |
Noticed the spammer latency docs describe generated files as
tx_latency_<yyyymmdd>_<hhmmss>.csv, but the analysis examples used a differenttx-latency-...name.Updated the examples to use the same filename format that the spammer actually writes.
Testing:
git diff --checkpython3 scripts/test_tx_latency_report.py