Skip to content

Update the launcher to Java 17 #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leMaik merged 2 commits into from
Jul 26, 2026
Merged

Update the launcher to Java 17 #1904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05ce4e8
Update lib and launcher to Java 17.
leMaik Jul 25, 2026
bc44898
Remove obsolete error handling for Java 8.
leMaik Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ subprojects {

java {
toolchain {
// default java version for the project, some subprojects are pinned to java 8 for backwards compatibility (see their configs).
// default java version for the project
languageVersion = JavaLanguageVersion.of(17)
}
}
Expand Down
4 changes: 0 additions & 4 deletions chunky/src/java/se/llbit/chunky/resources/ResourcePackLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,10 +224,6 @@ public static FileSystem getPackFileSystem(File pack) throws IOException {
? FileSystems.getDefault()
// for resource packs in jar or zip files
: FileSystems.newFileSystem(URI.create("jar:" + pack.toURI()), Collections.emptyMap());
} catch (ZipError e) {
// This catch is required for Java 8. This error appears safe to catch.
// https://stackoverflow.com/a/51715939
throw new IOException(e);
} catch (FileSystemAlreadyExistsException e) {
// for resource packs in jar or zip files (re-use existing fs)
return FileSystems.getFileSystem(URI.create("jar:" + pack.toURI()));
Expand Down
11 changes: 9 additions & 2 deletions launcher/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
apply plugin: 'application'
apply plugin: 'org.openjfx.javafxplugin'

mainClassName = 'se.llbit.chunky.launcher.ChunkyLauncher'

Expand All @@ -20,11 +21,17 @@ dependencies {

java {
toolchain {
languageVersion = JavaLanguageVersion.of(8) // pinned to java 8 for backwards compatibility
vendor = JvmVendorSpec.AMAZON // using corretto as it's one of few jdks to include jfx (on windows+linux) and isn't oracle
// keep this pinned to java 17 for backwards compatibility even if we update to Java 25 in Chunky 2.6
languageVersion = JavaLanguageVersion.of(17)
}
}

javafx {
version = '17'
configuration = 'implementation'
modules = ['javafx.base', 'javafx.controls', 'javafx.fxml']
}

sourceSets {
main {
java {
Expand Down
12 changes: 10 additions & 2 deletions lib/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
apply plugin: 'org.openjfx.javafxplugin'

sourceSets.main.java {
srcDir 'src'
}
Expand All @@ -8,7 +10,13 @@ configurations {

java {
toolchain {
languageVersion = JavaLanguageVersion.of(8) // pinned to java 8 for backwards compatibility
vendor = JvmVendorSpec.AMAZON // using corretto as it's one of few jdks to include jfx (on windows+linux) and isn't oracle
// keep this pinned to java 17 for backwards compatibility even if we update to Java 25 in Chunky 2.6
languageVersion = JavaLanguageVersion.of(17)
}
}

javafx {
version = '17'
configuration = 'implementation'
modules = ['javafx.base', 'javafx.controls', 'javafx.fxml']
}
Loading