Skip to content

security: add authorization checks to TransactionHttpHandler #16098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mohammadmseet-hue wants to merge 1 commit into
base: develop
Choose a base branch
from
+18 −1
Open

security: add authorization checks to TransactionHttpHandler #16098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion cdap-app-fabric/src/main/java/io/cdap/cdap/gateway/handlers/TransactionHttpHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@
import io.cdap.cdap.common.security.AuditPolicy;
import io.cdap.cdap.data2.transaction.TransactionSystemClientAdapter;
import io.cdap.cdap.gateway.handlers.util.AbstractAppFabricHttpHandler;
import io.cdap.cdap.proto.id.InstanceId;
import io.cdap.cdap.proto.security.StandardPermission;
import io.cdap.cdap.security.spi.authorization.ContextAccessEnforcer;
import io.cdap.http.BodyProducer;
import io.cdap.http.HandlerContext;
import io.cdap.http.HttpResponder;
Expand Down Expand Up @@ -79,15 +82,17 @@ public class TransactionHttpHandler extends AbstractAppFabricHttpHandler {
private final Configuration hConf;
private final CConfiguration cConf;
private final TransactionSystemClient txClient;
private final ContextAccessEnforcer contextAccessEnforcer;
private final boolean pruneEnable;
private volatile InvalidListPruningDebug pruningDebug;

@Inject
public TransactionHttpHandler(Configuration hConf, CConfiguration cConf,
TransactionSystemClient txClient) {
TransactionSystemClient txClient, ContextAccessEnforcer contextAccessEnforcer) {
this.hConf = hConf;
this.cConf = cConf;
this.txClient = new TransactionSystemClientAdapter(txClient);
this.contextAccessEnforcer = contextAccessEnforcer;
this.pruneEnable = cConf.getBoolean(TxConstants.TransactionPruning.PRUNE_ENABLE,
TxConstants.TransactionPruning.DEFAULT_PRUNE_ENABLE);
}
Expand All @@ -99,6 +104,7 @@ public TransactionHttpHandler(Configuration hConf, CConfiguration cConf,
@GET
public void getTxManagerSnapshot(HttpRequest request, HttpResponder responder)
throws TransactionCouldNotTakeSnapshotException, IOException {
contextAccessEnforcer.enforce(InstanceId.SELF, StandardPermission.GET);
LOG.trace("Taking transaction manager snapshot at time {}", System.currentTimeMillis());
LOG.trace("Took and retrieved transaction manager snapshot successfully.");

Expand Down Expand Up @@ -138,6 +144,7 @@ public void handleError(@Nullable Throwable cause) {
@POST
public void invalidateTx(HttpRequest request, HttpResponder responder,
@PathParam("tx-id") String txId) {
contextAccessEnforcer.enforce(InstanceId.SELF, StandardPermission.UPDATE);
try {
long txIdLong = Long.parseLong(txId);
boolean success = txClient.invalidate(txIdLong);
Expand All @@ -159,6 +166,7 @@ public void invalidateTx(HttpRequest request, HttpResponder responder,
@AuditPolicy(AuditDetail.REQUEST_BODY)
public void truncateInvalidTxBefore(FullHttpRequest request,
HttpResponder responder) throws InvalidTruncateTimeException {
contextAccessEnforcer.enforce(InstanceId.SELF, StandardPermission.UPDATE);
Map<String, Long> body;
try {
body = parseBody(request, STRING_LONG_MAP_TYPE);
Expand All @@ -181,6 +189,7 @@ public void truncateInvalidTxBefore(FullHttpRequest request,
@POST
@AuditPolicy(AuditDetail.REQUEST_BODY)
public void truncateInvalidTx(FullHttpRequest request, HttpResponder responder) {
contextAccessEnforcer.enforce(InstanceId.SELF, StandardPermission.UPDATE);
Map<String, Set<Long>> body;
try {
body = parseBody(request, STRING_LONG_SET_MAP_TYPE);
Expand All @@ -202,6 +211,7 @@ public void truncateInvalidTx(FullHttpRequest request, HttpResponder responder)
@Path("/transactions/invalid/size")
@GET
public void invalidTxSize(HttpRequest request, HttpResponder responder) {
contextAccessEnforcer.enforce(InstanceId.SELF, StandardPermission.GET);
int invalidSize = txClient.getInvalidSize();
responder.sendJson(HttpResponseStatus.OK,
GSON.toJson(Collections.singletonMap("size", invalidSize)));
Expand All @@ -211,6 +221,7 @@ public void invalidTxSize(HttpRequest request, HttpResponder responder) {
@GET
public void invalidList(HttpRequest request, HttpResponder responder,
@QueryParam("limit") @DefaultValue("-1") int limit) {
contextAccessEnforcer.enforce(InstanceId.SELF, StandardPermission.GET);
Transaction tx = txClient.startShort();
txClient.abort(tx);
long[] invalids = tx.getInvalids();
Expand All @@ -228,6 +239,7 @@ public void invalidList(HttpRequest request, HttpResponder responder,
@Path("/transactions/state")
@POST
public void resetTxManagerState(HttpRequest request, HttpResponder responder) {
contextAccessEnforcer.enforce(InstanceId.SELF, StandardPermission.UPDATE);
txClient.resetState();
responder.sendStatus(HttpResponseStatus.OK);
}
Expand All @@ -238,6 +250,7 @@ public void resetTxManagerState(HttpRequest request, HttpResponder responder) {
@Path("/transactions/prune/now")
@POST
public void pruneNow(HttpRequest request, HttpResponder responder) {
contextAccessEnforcer.enforce(InstanceId.SELF, StandardPermission.UPDATE);
txClient.pruneNow();
responder.sendStatus(HttpResponseStatus.OK);
}
Expand All @@ -247,6 +260,7 @@ public void pruneNow(HttpRequest request, HttpResponder responder) {
@GET
public void getPruneInfo(HttpRequest request, HttpResponder responder,
@PathParam("region-name") String regionName) {
contextAccessEnforcer.enforce(InstanceId.SELF, StandardPermission.GET);
try {
if (!initializePruningDebug(responder)) {
return;
Expand All @@ -269,6 +283,7 @@ public void getPruneInfo(HttpRequest request, HttpResponder responder,
@GET
public void getTimeRegions(HttpRequest request, HttpResponder responder,
@QueryParam("time") @DefaultValue("now") String time) {
contextAccessEnforcer.enforce(InstanceId.SELF, StandardPermission.GET);
try {
if (!initializePruningDebug(responder)) {
return;
Expand All @@ -287,6 +302,7 @@ public void getTimeRegions(HttpRequest request, HttpResponder responder,
public void getIdleRegions(HttpRequest request, HttpResponder responder,
@QueryParam("limit") @DefaultValue("-1") int numRegions,
@QueryParam("time") @DefaultValue("now") String time) {
contextAccessEnforcer.enforce(InstanceId.SELF, StandardPermission.GET);
try {
if (!initializePruningDebug(responder)) {
return;
Expand All @@ -306,6 +322,7 @@ public void getIdleRegions(HttpRequest request, HttpResponder responder,
public void getRegionsToBeCompacted(HttpRequest request, HttpResponder responder,
@QueryParam("limit") @DefaultValue("-1") int numRegions,
@QueryParam("time") @DefaultValue("now") String time) {
contextAccessEnforcer.enforce(InstanceId.SELF, StandardPermission.GET);
try {
if (!initializePruningDebug(responder)) {
return;
Expand Down