Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #3218 +/- ##
==========================================
+ Coverage 91.18% 91.19% +0.01%
==========================================
Files 205 205
Lines 9101 9110 +9
==========================================
+ Hits 8298 8307 +9
Misses 803 803 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--benchmark-resamples=0currently parses successfully, even though the bootstrap analysis needs a nonempty set of resamples. Reject zero at the command-line boundary, mirroring the existing validation of--benchmark-samples.Use
parseUIntto validate the value before updatingConfigData, and report a specific error for malformed input. Add command-line regressions for zero and nonnumeric input, retain the existing positive-value test, document the constraint, and update the SelfTest approval baselines. No amalgamated files are changed.Validation on Windows with Clang 23.1.3/libc++, C++14, and the
basic-testsdevelopment preset:tools/scripts/approve.py.GitHub Issues
No linked issue; this change is limited to command-line validation of the resample count.