feat: add payment-method abstraction - #1131
Open
a1denvalu3 wants to merge 9 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1131 +/- ##
==========================================
- Coverage 74.85% 74.03% -0.82%
==========================================
Files 112 119 +7
Lines 12589 13492 +903
==========================================
+ Hits 9423 9989 +566
- Misses 3166 3503 +337 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/v1/.../bolt11endpoints, defaults, wire fields, and legacy wallet tables for older clientsThis establishes the abstraction boundary for methods such as BOLT12 or on-chain payments without adding or advertising a new production payment rail.
Compatibility
Validation
git diff --check: passedmake checkstill reports two unrelated existing Optional-path mypy errors incashu/mint/management_rpc/management_rpc.py.Review notes
This includes additive schema and protocol-boundary work, so it requires maintainer review under the repository contribution policy.