feat(mint): advertise the maximum request array length - #1115
Merged
a1denvalu3 merged 2 commits intoSep 1, 2026
Conversation
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1115 +/- ##
==========================================
- Coverage 74.49% 74.43% -0.07%
==========================================
Files 115 113 -2
Lines 13160 12756 -404
==========================================
- Hits 9804 9495 -309
+ Misses 3356 3261 -95 ☔ View full report in Codecov by Harness. |
Nothing tells a wallet how long an array in a request may be, so it finds out by getting an error partway through one it has already built. Serve the existing mint_max_request_length setting as the NUT-06 max_request_length field.
robwoodgate
force-pushed
the
feat/nut06-max-request-length
branch
from
August 13, 2026 21:00
f5d358b to
917bd11
Compare
a1denvalu3
approved these changes
Aug 14, 2026
Follows the NUT-06 field rename. The old name reads like a cap on the request body in bytes. The mint_max_request_length setting is unchanged.
Contributor
Author
|
EDIT: Updated NUT-06 key name to: |
a1denvalu3
approved these changes
Sep 1, 2026
Collaborator
|
ACK. NUT change is merged therefore merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements cashubtc/nuts#425.
Adds the optional NUT-06
max_array_lengthto/v1/infoso wallets can size their batches up front instead of discovering the cap by getting an error partway through a request.The value is the existing
mint_max_request_lengthsetting, which already bounds every request array, so this only surfaces what the mint enforces today.