feat(lightning): probe LND routing fees - #1095
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1095 +/- ##
==========================================
+ Coverage 74.82% 74.84% +0.02%
==========================================
Files 112 112
Lines 12589 12612 +23
==========================================
+ Hits 9420 9440 +20
- Misses 3169 3172 +3 ☔ View full report in Codecov by Harness. |
|
Rationale for the updated fee handling:
At payment time, the mint already converts the stored quote reserve to msat and passes that exact value to LND as |
callebtc
left a comment
There was a problem hiding this comment.
very nice. not ready yet?
f89770e to
7de5d9d
Compare
Summary
EstimateRouteFeeAPI when creating full-invoice melt quotesTesting
make checkpytest -q tests/lightning/test_lightning_backends_mocked.py tests/lightning/test_fee_unit_regressions.py(37 passed)test_lnd_payment_quote_uses_probed_fee(passed)test_lnd_payment_quote_uses_probed_fee(passed)The regtest requests a 100,000 sat CLN node 2 invoice that requires a multi-hop route from LND node 3. It asserts that the returned fee is non-zero and lower than the blind percentage-based reserve.