fix(core): treat mint quote expiry as advisory - #397
Merged
Conversation
🦋 Changeset detectedLatest commit: 766696d The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Egge21M
marked this pull request as ready for review
July 29, 2026 13:07
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #397 +/- ##
==========================================
- Coverage 92.65% 92.63% -0.03%
==========================================
Files 112 111 -1
Lines 17694 17633 -61
==========================================
- Hits 16395 16334 -61
Misses 1299 1299
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes local Mint Quote expiry handling so expiry is advisory payment-deadline metadata.
Problem
Coco treated elapsed Mint Quote expiry as terminal in claimability, preparation, recovery, and watcher paths. That could hide valid accounting increases, block issuance of paid value, or stop observing quotes that can still resolve after expiry.
Summary
Melt Quote expiry semantics and existing mint-rejection error handling are unchanged.
Verification
bun test test/unit/MintOperationService.test.ts test/unit/MintOperationWatcherService.test.ts test/unit/MintBolt12Handler.test.ts test/unit/MintOnchainHandler.test.ts test/unit/HybridTransport.test.ts— 162 passedbun run --filter='@cashu/coco-core' test:unit— 1,149 passedbun run --filter='@cashu/coco-core' typecheckbun run --filter='@cashu/coco-core' buildgit diff --checkThis pull request resolves #390.