refactor(sigall): recompute signing digests from package contents [backport v4-dev] - #951
Merged
Conversation
(cherry picked from commit 20a29e2)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4-dev #951 +/- ##
=========================================
Coverage ? 95.46%
=========================================
Files ? 49
Lines ? 5162
Branches ? 1290
=========================================
Hits ? 4928
Misses ? 100
Partials ? 134
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Nutshell 0.20.3 and mintd 0.17.3 / 0.17.3-rc.0. Nutshell releases before 0.20.3 do not verify the SIG_ALL message format the wallet now produces.
75 tasks
robwoodgate
added a commit
that referenced
this pull request
Aug 12, 2026
Mostly hardening fixes, a couple of minor breaking changes to note: Experimental — SigAll (#951): 1. SigAllDigests reshaped: { legacy, current } → { v0 }. 2. SigAllSigningPackage.digests removed — digests are recomputed from package contents. 3. deserializePackage(input, options?) → deserializePackage(input); the validateDigest option is gone, validation is now implicit. Stable, type-level (#958): 4. NUT10Option.tags required → optional. 5. RawNUT10Option.t required → optional. Both only affect TypeScript consumers who read the field, who now see | undefined. Constructing gets easier, and it matches NUT-10 and NUT-18, which both call tags optional. Stable, behavioural (#932): 6. New bolt11 quote-amount check that throws, at four call sites including the read paths checkMintQuoteBolt11 and checkMintQuoteBatchBolt11. Only affects non-compliant mints that return ln invoices that do not match the quote amounts, so should not break in practice. Thanks to Project Loupe for suggesting some of the hardening fixes in this release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #947 to
v4-dev.