Skip to content

fix: use generic NUT-17 subscription kinds - #665

Closed
callebtc wants to merge 1 commit into
mainfrom
fix/nut17-generic-subscription-kinds
Closed

fix: use generic NUT-17 subscription kinds#665
callebtc wants to merge 1 commit into
mainfrom
fix/nut17-generic-subscription-kinds

Conversation

@callebtc

Copy link
Copy Markdown
Contributor

Summary

  • switch wallet websocket subscriptions to the new generic mint_quote and melt_quote kinds
  • keep the old bolt11-specific kinds in the public RPC type as deprecated aliases for backwards compatibility
  • update NUT-17 test fixtures and websocket tests to advertise and expect the new command strings

Testing

  • npx vitest run --project node test/transport/WSConnection.test.ts test/wallet/WalletEvents.test.ts test/wallet/wallet.node.test.ts
  • npx vitest run --project node test/wallet/bolt12.test.ts test/transport/request.node.test.ts

Refs: cashubtc/nuts#372

@robwoodgate

Copy link
Copy Markdown
Collaborator

Closing in favour of #668, which is exactly the same patch, just applied cleanly to current state of main.

The PR above was based on a very old state of main, making rebase more difficult than a new PR.

@github-project-automation github-project-automation Bot moved this from Backlog to Done in cashu-ts May 21, 2026
@robwoodgate
robwoodgate deleted the fix/nut17-generic-subscription-kinds branch May 22, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants