Report a malformed github release slug instead of panicking - #461
Open
arpitjain099 wants to merge 1 commit into
Open
Report a malformed github release slug instead of panicking#461arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
fetchTagSelection splits opts.Slug on / and indexes element 1 without
checking. Nothing validates the slug's shape between vendir.yml and that
line, so a config with a missing organization, e.g.
githubRelease:
slug: myrepo
tagSelection: {...}
crashes the sync:
panic: runtime error: index out of range [1] with length 1
The split happens before the API call, so it fails with no network and
without a token. Return the format error instead.
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetchTagSelectionsplitsopts.Slugon/and indexes element 1 without checking the result:Nothing between
vendir.ymland that line checks the slug's shape.DirectoryContentsGithubRelease.Slugis a plain string with an// e.g. organization/repositorycomment, and I could not find a format check anywhere in the tree. So a config that omits the organization crashes the sync:The split runs before the first API call, so it happens with no network access and no token configured.
strings.Cutnow covers it, and empty owner or repo halves (/repo,owner/) are rejected too. The message names the expected format so the fix is obvious from the output.The test drives
fetchTagSelectiondirectly for all four malformed shapes, which needs no client. It panics without the change.