feat: add support for native generic types#1826
Draft
azjezz wants to merge 7 commits into
Draft
Conversation
Signed-off-by: azjezz <azjezz@protonmail.com>
Signed-off-by: azjezz <azjezz@protonmail.com>
Signed-off-by: azjezz <azjezz@protonmail.com>
Signed-off-by: azjezz <azjezz@protonmail.com>
Signed-off-by: azjezz <azjezz@protonmail.com>
Signed-off-by: azjezz <azjezz@protonmail.com>
Signed-off-by: azjezz <azjezz@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not a final implementation, just trying it out here. We would need many tests ( currently this PR has none ), initial goal is to first thread the new syntax through all tools ( formatter, linter, semantics checker, analyzer, …), then verify correctness against php-src tests ( the compile-time/link-time errors ).
Codex is going to be the tricky one, this PR treats the new generics the same as the ones that are in the docblocks, but, that's wrong. the new PHP syntax allows for
class A implements Foo<string>, Foo<int> {}which is not something possible currently using docblocks ( i.e implementing the same interface twice ) - at least not in Mago.ref php/php-src#21969