Skip to content

Added --distro and --rmw arguments to run_rviz.sh to be able to#9672

Open
LuisPovedaCano wants to merge 2 commits intoue4-devfrom
luis/update_ros_example
Open

Added --distro and --rmw arguments to run_rviz.sh to be able to#9672
LuisPovedaCano wants to merge 2 commits intoue4-devfrom
luis/update_ros_example

Conversation

@LuisPovedaCano
Copy link
Copy Markdown
Contributor

@LuisPovedaCano LuisPovedaCano commented Apr 14, 2026

Summary

  • Replaces the hardcoded osrf/ros:humble-desktop image and rmw_cyclonedds_cpp middleware in the ROS2 RViz example with configurable --distro and --rmw arguments.
  • Adds a unified parametrized Dockerfile that builds the correct image for any supported distro/RMW combination
  • Supported distros: humble, jazzy
  • Supported middlewares: fastdds, cyclonedds

Usage

Default: humble + fastdds

./PythonAPI/examples/ros2/run_rviz.sh

Explicit combination

./PythonAPI/examples/ros2/run_rviz.sh --distro=jazzy --rmw=cyclonedds

Each distro/RMW combination builds and caches a separate image (carla-rviz--), so switching between them doesn't require a rebuild.

Related Issues:
During the testing of the new example I've noticed 3 issues

@JesusAnaya have you ever seen any of these?


This change is Reviewable

run the example with ROS2 distros `Humble` and `Jazzy` and RMW `FastDDS`
and `CycloneDDS`
@LuisPovedaCano LuisPovedaCano requested a review from joel-mb April 14, 2026 14:50
@LuisPovedaCano LuisPovedaCano self-assigned this Apr 14, 2026
@LuisPovedaCano LuisPovedaCano requested a review from a team as a code owner April 14, 2026 14:50
@update-docs
Copy link
Copy Markdown

update-docs bot commented Apr 14, 2026

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes.

@JesusAnaya
Copy link
Copy Markdown
Contributor

Hello, I didn't see the issues before. I can take a look and see how to address them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants