[backend] Use C++ standard types in snapshots#4798
Open
Conversation
dd57ea8 to
e34776c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4798 +/- ##
==========================================
- Coverage 87.53% 87.52% -0.00%
==========================================
Files 258 258
Lines 14154 14153 -1
==========================================
- Hits 12388 12386 -2
- Misses 1766 1767 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tobe2098
requested changes
Apr 24, 2026
Contributor
tobe2098
left a comment
There was a problem hiding this comment.
Nice work deQting the codebase Jim! Just a small question about vm_name, but the rest looks good to go 👍
| } | ||
|
|
||
| bool snapshot_exists(mp::PowerShell& ps, const QString& vm_name, const QString& id) | ||
| bool snapshot_exists(mp::PowerShell& ps, const QString& vm_name, const std::string& id) |
Contributor
There was a problem hiding this comment.
Strictly speaking, should we not move this QString to std::string as well?
| } | ||
|
|
||
| void require_unique_id(mp::PowerShell& ps, const QString& vm_name, const QString& id) | ||
| void require_unique_id(mp::PowerShell& ps, const QString& vm_name, const std::string& id) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This converts our snapshot code to use C++ standard types, with the notable exception of
QDateTime. (While that wouldn't be hard to convert as well, I think it would make more sense to do all theQDateTimeconversion in a separate PR.)Testing
sudo ./bin/multipassd./bin/multipass launch --name foo./bin/multipass stop foo && ./bin/multipass snapshot fooChecklist