Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4797 +/- ##
=======================================
Coverage 87.45% 87.45%
=======================================
Files 258 258
Lines 14094 14094
=======================================
Hits 12324 12324
Misses 1770 1770 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1cb526f to
fe9b0bd
Compare
bc37f97 to
c2db765
Compare
Collaborator
Author
|
Requesting a review from @geoffreynyaga as this is kinda related to documentation. Curious if there is a company wide standard for how to handle localization. |
c2db765 to
40c77fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts the various user facing strings out of the Dart source code and places them in a dedicated resource file which provides several benefits:
Localization is handled by the
l10npackage and is the canonical Flutter method of internationalizing Flutter apps. Additional localizations are placed under**/lib/l10n/*where localization files are generated during the build process.For more info, see: